From owner-freebsd-commit Mon Jul 17 06:53:59 1995 Return-Path: commit-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id GAA00457 for commit-outgoing; Mon, 17 Jul 1995 06:53:59 -0700 Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id GAA00444 for cvs-usrbin-outgoing; Mon, 17 Jul 1995 06:53:55 -0700 Received: from deep-thought.demos.su (root@deep-thought.demos.su [192.91.186.133]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id GAA00436 ; Mon, 17 Jul 1995 06:53:33 -0700 Received: by deep-thought.demos.su id RAA00530; (8.6.11/D) Mon, 17 Jul 1995 17:51:20 +0400 To: CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com, Peter Wemm References: <199507171237.FAA28276@freefall.cdrom.com> In-Reply-To: <199507171237.FAA28276@freefall.cdrom.com>; from Peter Wemm at Mon, 17 Jul 1995 05:37:54 -0700 Message-ID: Organization: DEMOS Date: Mon, 17 Jul 1995 17:51:20 +0400 (MSD) X-Mailer: Mail/@ [v2.40 FreeBSD] From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= aka "Andrey A. Chernov, Black Mage" X-Class: Fast Subject: Re: cvs commit: src/usr.bin/more main.c Lines: 36 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Length: 969 Sender: commit-owner@freebsd.org Precedence: bulk In message <199507171237.FAA28276@freefall.cdrom.com> Peter Wemm writes: >peter 95/07/17 05:37:52 > Modified: usr.bin/more main.c > Log: > Make 'more' sensative to the current locale for it's ctype calls. > Submitted by: Thomas Gellekum, with minor cosmetic changes from me. Please, back out this commit. 1) It breaks rune chars totally, more isn't ready to support chars > 8bits, but tries with this patch! 2) Such functionality ALREDY EXISTS! Shure, you don't need to add such stuff to each ctype program even for 8bit chars! All you need is setenv ENABLE_STARTUP_LOCALE for it. ENABLE_STARTUP_LOCALE is smart enough to not turn it on for 16bit chars. BTW, I suggest that all locale changes need goes through my review first to avoid such obviosly wrong cases. -- Andrey A. Chernov : ache@FreeBSD.org : From 33th IETF FidoNet: 2:5020/230.3 : Stockholm RELCOM Team,FreeBSD Team :