From owner-freebsd-ports Mon Aug 12 03:11:53 1996 Return-Path: owner-ports Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA12016 for ports-outgoing; Mon, 12 Aug 1996 03:11:53 -0700 (PDT) Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id DAA11858; Mon, 12 Aug 1996 03:05:47 -0700 (PDT) Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.7.5/8.6.9) id DAA02891; Mon, 12 Aug 1996 03:05:28 -0700 (PDT) Date: Mon, 12 Aug 1996 03:05:28 -0700 (PDT) Message-Id: <199608121005.DAA02891@silvia.HIP.Berkeley.EDU> To: ports@freebsd.org, committers@freebsd.org Subject: review request: INSTALL_* aliases in bsd.port.mk From: asami@cs.berkeley.edu (Satoshi Asami) Sender: owner-ports@freebsd.org X-Loop: FreeBSD.org Precedence: bulk I noticed that there are a lot of cp commands in the *-install targets in ports' Makefiles. What do you guys think about adding these to bsd.port.mk so that we can just say do-install: ${INSTALL_PROGRAM} ${WRKSRC}/coolprog ${PREFIX}/bin ${INSTALL_MAN} ${WRKSRC}/coolprog.1 ${PREFIX}/man/man1 .if !defined(NOMANCOMPRESS) : instead of the long-but-correct alternatives, and, um, the bazillion may-be-short-but-incorrect alternatives? Note that this is only for toplevel Makefiles, and won't affect anything in the software's own Makefiles. Satoshi ------- Index: bsd.port.mk =================================================================== RCS file: /usr/cvs/src/share/mk/bsd.port.mk,v retrieving revision 1.218 diff -u -r1.218 bsd.port.mk --- bsd.port.mk 1996/08/07 08:25:08 1.218 +++ bsd.port.mk 1996/08/12 09:37:37 @@ -316,6 +316,16 @@ NO_MTREE= yes .endif +# A few aliases for *-install targets +INSTALL_PROGRAM= \ + ${INSTALL} ${COPY} ${STRIP} -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} +INSTALL_SCRIPT= \ + ${INSTALL} ${COPY} -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} +INSTALL_DATA= \ + ${INSTALL} ${COPY} -o ${SHAREOWN} -g ${SHAREGRP} -m ${SHAREMODE} +INSTALL_MAN= \ + ${INSTALL} ${COPY} -o ${MANOWN} -g ${MANGRP} -m ${MANMODE} + # The user can override the NO_PACKAGE by specifying this from # the make command line .if defined(FORCE_PACKAGE)