From owner-freebsd-current  Sat Feb 10  8:54:43 2001
Delivered-To: freebsd-current@freebsd.org
Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20])
	by hub.freebsd.org (Postfix) with ESMTP
	id EFFAD37B4EC; Sat, 10 Feb 2001 08:54:17 -0800 (PST)
Received: (from bright@localhost)
	by fw.wintelcom.net (8.10.0/8.10.0) id f1AGsGi26440;
	Sat, 10 Feb 2001 08:54:16 -0800 (PST)
Date: Sat, 10 Feb 2001 08:54:16 -0800
From: Alfred Perlstein <bright@wintelcom.net>
To: Jeroen Ruigrok/Asmodai <asmodai@wxs.nl>
Cc: current@FreeBSD.ORG, smp@FreeBSD.ORG
Subject: Re: Current SMP Kernel panics
Message-ID: <20010210085416.H3274@fw.wintelcom.net>
References: <5.0.2.1.2.20010209204045.00ac42a8@pozo.com> <20010210162033.C406@daemon.ninth-circle.org> <20010210172417.F406@daemon.ninth-circle.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010210172417.F406@daemon.ninth-circle.org>; from asmodai@wxs.nl on Sat, Feb 10, 2001 at 05:24:17PM +0100
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

* Jeroen Ruigrok/Asmodai <asmodai@wxs.nl> [010210 08:24] wrote:
> -On [20010210 16:27], Jeroen Ruigrok/Asmodai (asmodai@wxs.nl) wrote:
> >#ifdef SMP
> >	mtx_lock_spin(&sched_lock);
> >	need_resched();
> >	forward_roundrobin();
> >	mtx_unlock_spin(&sched_lock);
> >#else
> 
> This does not quite work.
> 
> I don't get the panic() anymore, but now I have solve the hanging. :)
> 
> Perhaps only need_resched() needs to be spinlocked.  I am not sure, I am
> not a SMP guru.

That looks correct, need_resched() needs sched_lock.

I'm currently looking to see if forward_roundrobin() does as well.


-- 
-Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org]
"I have the heart of a child; I keep it in a jar on my desk."


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message