From owner-freebsd-hackers Fri Feb 7 22: 0:11 2003 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D54CA37B401 for ; Fri, 7 Feb 2003 22:00:10 -0800 (PST) Received: from skywalker.creative.net.au (skywalker.creative.net.au [203.56.168.1]) by mx1.FreeBSD.org (Postfix) with SMTP id 1F01243FA3 for ; Fri, 7 Feb 2003 22:00:09 -0800 (PST) (envelope-from freebsd@skywalker.creative.net.au) Received: (qmail 31627 invoked by uid 1008); 8 Feb 2003 06:00:04 -0000 Date: Sat, 8 Feb 2003 14:00:03 +0800 From: Adrian Chadd To: Giorgos Keramidas Cc: freebsd-hackers@freebsd.org Subject: Re: adduser change: telling you when a group isn't there Message-ID: <20030208060003.GA31217@skywalker.creative.net.au> References: <20030207081056.GA84685@skywalker.creative.net.au> <20030208054207.GC986@gothmog.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030208054207.GC986@gothmog.gr> User-Agent: Mutt/1.4i Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Feb 08, 2003, Giorgos Keramidas wrote: > It doesn't need to ( read as "should not" ) check for all the groups > involved, since when the group is the same as the username, it's > obvious that it will probably not exist. But if it already does, is > it an error? I think not, since one might want to create many users > who share the same group. > > What do you all think about the following patch then? [snip patch] I used pw to try and avoid directly hitting up file contents in case the admin has done something whacky in the nsswitch stakes. Everything else in adduser.sh uses pw AFAICT. Adrian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message