From owner-svn-src-all@freebsd.org Tue Jul 21 08:41:14 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C7D8E9A7953 for ; Tue, 21 Jul 2015 08:41:14 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 80DD31E09 for ; Tue, 21 Jul 2015 08:41:14 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: by wgbcc4 with SMTP id cc4so56839091wgb.3 for ; Tue, 21 Jul 2015 01:41:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=PWvxtlGt/QOB2gMXehym+M8kgOi5tOnCMalPxf7hPr8=; b=W4077ZdGMbC5uNIujC38FS3aiZvVGil6AHGV6l+BAViXOEMUQbM1z+aRii1WIlW4/F wYj7MU4jWGQK5A/kt4J9dBNLv//7rWvccAW63PsSW9alpAppY3Z7wAxcRMt8T/4NRU2n +ydONsIpCUzlbYlo2x281tZDcfzTOUNk30E6g1nw/w6E6NVMgXm8bs069g+6l9X/bfkv sRIlp7lcAl8uiHu34P5MXoC+mPBbcyVJshEugyZjMzRoUZxGGk4r/mn+GjKcGWcxiIl+ OS6Opv5PaNYcn1yled8qTpC1MzWx6PY2ORHgfaM7RjhJN7zXabgK4OX+Vlasbn0v2Z49 4kAA== X-Gm-Message-State: ALoCoQmbiBxyJKy/EW4Kq6dRaaAyTCPtmR2tPk0tfaJS2wkDtIJ5lD8s6orecnS9vkZ6ZVF5b0VI X-Received: by 10.180.210.177 with SMTP id mv17mr28727662wic.90.1437468067557; Tue, 21 Jul 2015 01:41:07 -0700 (PDT) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by smtp.gmail.com with ESMTPSA id di7sm15599488wib.23.2015.07.21.01.41.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Jul 2015 01:41:06 -0700 (PDT) Subject: Re: svn commit: r285731 - stable/10/sys/dev/ixgbe To: "Andrey V. Elsukov" , Hiren Panchasara , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org References: <201507210031.t6L0VEKZ043473@repo.freebsd.org> <55ADE636.4020608@yandex.ru> From: Steven Hartland Message-ID: <55AE059F.5080104@multiplay.co.uk> Date: Tue, 21 Jul 2015 09:41:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55ADE636.4020608@yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2015 08:41:14 -0000 The only documented version is the sysctl, this fixes the miss-match from that and the tunable, hence only those that have edited the source to find the mistake would be using the invalid setting, everyone will be just not getting the value they have requested. I would however suggest adding a entry to UPDATING. Regards Steve On 21/07/2015 07:27, Andrey V. Elsukov wrote: > On 21.07.2015 03:31, Hiren Panchasara wrote: >> Author: hiren >> Date: Tue Jul 21 00:31:13 2015 >> New Revision: 285731 >> URL: https://svnweb.freebsd.org/changeset/base/285731 >> >> Log: >> Fix a typo in r285668. Replace hw.ixgbe.* with correct hw.ix.* for a couple of >> sysctls. > This looks like a POLA violation. >