Date: Tue, 03 Dec 2013 09:50:07 -0600 From: Mark Felder <feld@feld.me> To: Stefan Wendler <stefan.wendler@tngtech.com>, freebsd-hackers@freebsd.org Subject: Re: Kind of hacky fix for banshee-2.6.0 Message-ID: <1386085807.32047.54988641.54504273@webmail.messagingengine.com> In-Reply-To: <3074012.QmsohyHcnK@hactar> References: <3074012.QmsohyHcnK@hactar>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 2, 2013, at 14:28, Stefan Wendler wrote:
> Hi,
>
> I've noticed a long time ago that banshee was not compiling anymore. When
> I
> wrote the maintainer nobody replied. So I kind of dirty-hacky-fixed it
> myself
> today.
>
> I generally did the following:
>
> I the Makefile.in files of the sources I changed (where this variable was
> available)
> ASSEMBLY_BUILD_FLAGS = -unsafe
> to
> ASSEMBLY_BUILD_FLAGS = -unsafe -sdk:4
>
> Then I compiled my way through the rest of the sources and found loads of
> other files where this line was missing completely. I started by
> including it
> by hand but after the 20th Makefile.in it somehow got tedious.
>
> so I did a "export ASSEMBLY_BUILD_FLAGS = -unsafe -sdk:4" and then a make
> install. Now it compiles and banshee works.
>
> I attached the patch fle that can be copied to multimedia/banshee/files
> and
> works-for-me (TM)
> But I still have to do the export-thing before compiling. And I know this
> is a
> dirty hack. But I don't know if there is a way to include this once as a
> global compile time variable. Or if I have to patch this into every
> Makefile.in there is in banshee?
>
> Since I never did any patch at all for FreeBSD so far and didn't find
> anything
> about setting a global variable in the ports Makefile, I kind of hope
> that
> there is anybody out there who can guide me in the right direction?
>
Are all of these files Makefile.in or Makefile.am ? If so, this patch
would fix it:
Index: Makefile
===================================================================
--- Makefile (revision 335567)
+++ Makefile (working copy)
@@ -126,4 +126,8 @@
PLIST_SUB+= OPT_WEBKITORYOUTUBE="@comment "
.endif
+post-patch:
+ ${FIND} ${WRKSRC} -name 'Makefile.*' | ${XARGS} ${REINPLACE_CMD}
\
+ -E 's|ASSEMBLY_BUILD_FLAGS = -unsafe|ASSEMBLY_BUILD_FLAGS =
-unsafe -sdk:4|'
+
.include <bsd.port.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1386085807.32047.54988641.54504273>