From owner-cvs-all  Tue Aug 14  4:16:40 2001
Delivered-To: cvs-all@freebsd.org
Received: from gate.qubesoft.com (gate.qubesoft.com [212.113.16.243])
	by hub.freebsd.org (Postfix) with ESMTP
	id F317E37B407; Tue, 14 Aug 2001 04:16:21 -0700 (PDT)
	(envelope-from n_hibma@qubesoft.com)
Received: from bluebottle.qubesoft.com (bluebottle [192.168.1.2])
	by gate.qubesoft.com (8.11.3/8.11.3) with ESMTP id f7EBGKl12051;
	Tue, 14 Aug 2001 12:16:20 +0100 (BST)
	(envelope-from n_hibma@qubesoft.com)
Received: from builder03 (dhcp139.qubesoft.com [192.168.1.139])
	by bluebottle.qubesoft.com (8.11.4/8.11.4) with SMTP id f7EBGJI88105;
	Tue, 14 Aug 2001 12:16:19 +0100 (BST)
	(envelope-from n_hibma@qubesoft.com)
From: "Nick Hibma" <n_hibma@qubesoft.com>
To: "Julian Elischer" <julian@FreeBSD.org>,
	<cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject: RE: cvs commit: src/sys/dev/usb uhub.c
Date: Tue, 14 Aug 2001 12:16:19 +0100
Message-ID: <CEEKLNFIGKODPCCPEKLDKEGGCBAA.n_hibma@qubesoft.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2911.0)
In-Reply-To: <200108101732.f7AHWCq57068@freefall.freebsd.org>
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700
Importance: Normal
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

This is not the correct way to do it. usbd_devinfo should allocate the
buffer and return it. All drivers should be adapted to use an allocated
buffer.

Nick

> -----Original Message-----
> From: owner-cvs-committers@FreeBSD.org
> [mailto:owner-cvs-committers@FreeBSD.org]On Behalf Of Julian Elischer
> Sent: 10 August 2001 18:32
> To: cvs-committers@FreeBSD.org; cvs-all@FreeBSD.org
> Subject: cvs commit: src/sys/dev/usb uhub.c
>
>
> julian      2001/08/10 10:32:12 PDT
>
>   Modified files:
>     sys/dev/usb          uhub.c
>   Log:
>   Do NOT allocate a 1K buffer on the kernel stack.
>
>   Found by: Smashed u-area and hardware watch points.
>   MFC after: 1 week
>
>   Revision  Changes    Path
>   1.29      +13 -3     src/sys/dev/usb/uhub.c
>
>
> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/usb/uhub.c?r
> 1=1.28&r2=1.29&cvsroot=freebsd
>


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message