From owner-freebsd-current Tue Feb 25 6:46:29 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1225337B405; Tue, 25 Feb 2003 06:46:27 -0800 (PST) Received: from mail.tcoip.com.br (erato.tco.net.br [200.220.254.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id E48DD43FD7; Tue, 25 Feb 2003 06:46:21 -0800 (PST) (envelope-from dcs@tcoip.com.br) Received: from tcoip.com.br ([10.0.2.6]) by mail.tcoip.com.br (8.11.6/8.11.6) with ESMTP id h1PEkER15313; Tue, 25 Feb 2003 11:46:14 -0300 Message-ID: <3E5B81B6.5030402@tcoip.com.br> Date: Tue, 25 Feb 2003 11:46:14 -0300 From: "Daniel C. Sobral" User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3b) Gecko/20030214 X-Accept-Language: en-us, en, pt-br, ja MIME-Version: 1.0 To: Robert Watson Cc: current@freebsd.org Subject: Re: Witness This References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Now I think I was premature. It seems there is something unmacish in this kernel. Sigh. Well, I'll test with a recent source. Robert Watson wrote: > Ok, I've committed it. Saw your other panic message, hope to look more > closely today. > > BTW, you might consider running with the mac_test module, as it's intended > to help diagnose label problems through additional assertions. > > Robert N M Watson FreeBSD Core Team, TrustedBSD Projects > robert@fledge.watson.org Network Associates Laboratories > > On Tue, 25 Feb 2003, Daniel C. Sobral wrote: > > >>No bugs so far with this. >> >>Robert Watson wrote: >> >>>Revised patch without typo attached. >>> >>>Robert N M Watson FreeBSD Core Team, TrustedBSD Projects >>>robert@fledge.watson.org Network Associates Laboratories >>> >>>Index: tcp_subr.c >>>=================================================================== >>>RCS file: /data/fbsd-cvs/ncvs/src/sys/netinet/tcp_subr.c,v >>>retrieving revision 1.155 >>>diff -u -r1.155 tcp_subr.c >>>--- tcp_subr.c 21 Feb 2003 23:17:12 -0000 1.155 >>>+++ tcp_subr.c 22 Feb 2003 02:44:42 -0000 >>>@@ -484,7 +484,7 @@ >>> m->m_pkthdr.len = tlen; >>> m->m_pkthdr.rcvif = (struct ifnet *) 0; >>> #ifdef MAC >>>- if (tp != NULL) { >>>+ if (tp != NULL && tp->t_inpcb != NULL) { >>> /* >>> * Packet is associated with a socket, so allow the >>> * label of the response to reflect the socket label. >> >> >>-- >>Daniel C. Sobral (8-DCS) >>Gerencia de Operacoes >>Divisao de Comunicacao de Dados >>Coordenacao de Seguranca >>TCO >>Fones: 55-61-313-7654/Cel: 55-61-9618-0904 >>E-mail: Daniel.Capo@tco.net.br >> Daniel.Sobral@tcoip.com.br >> dcs@tcoip.com.br >> >>Outros: >> dcs@newsguy.com >> dcs@freebsd.org >> capo@notorious.bsdconspiracy.net >> >>I disagree with what you say, but will defend >>to the death your right to tell such LIES! >> >> -- Daniel C. Sobral (8-DCS) Gerencia de Operacoes Divisao de Comunicacao de Dados Coordenacao de Seguranca TCO Fones: 55-61-313-7654/Cel: 55-61-9618-0904 E-mail: Daniel.Capo@tco.net.br Daniel.Sobral@tcoip.com.br dcs@tcoip.com.br Outros: dcs@newsguy.com dcs@freebsd.org capo@notorious.bsdconspiracy.net The world needs more people like us and fewer like them. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message