From owner-cvs-all@FreeBSD.ORG Sun Jan 15 18:56:07 2012 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86A791065675 for ; Sun, 15 Jan 2012 18:56:07 +0000 (UTC) (envelope-from ale@FreeBSD.org) Received: from lab.alexdupre.com (alexdupre-1-pt.tunnel.tserv23.zrh1.ipv6.he.net [IPv6:2001:470:25:450::2]) by mx1.freebsd.org (Postfix) with ESMTP id 659F58FC14 for ; Sun, 15 Jan 2012 18:56:06 +0000 (UTC) Received: (qmail 63167 invoked from network); 15 Jan 2012 18:56:03 -0000 Received: from atom.alexdupre.com (HELO ?192.168.178.12?) (sysadmin@alexdupre.com@192.168.178.12) by lab.alexdupre.com with ESMTPSA; 15 Jan 2012 18:56:03 -0000 Message-ID: <4F132141.8020806@FreeBSD.org> Date: Sun, 15 Jan 2012 19:56:01 +0100 From: Alex Dupre User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0.1) Gecko/20111221 Firefox/9.0.1 SeaMonkey/2.6.1 MIME-Version: 1.0 To: Sunpoet Po-Chuan Hsieh References: <201201130917.q0D9HfbF078269@repoman.freebsd.org> <20120114092733.GA45406@bonjour.sunpoet.net> In-Reply-To: <20120114092733.GA45406@bonjour.sunpoet.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/print/pdflib Makefile pkg-plist ports/print/pdflib/files patch-configure ports/print/pdflib-perl Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jan 2012 18:56:07 -0000 Sunpoet Po-Chuan Hsieh ha scritto: > Hi Alex, > > I was confused by the conditional PERL OPTIONS. > > .if defined(WITH_PERL) > OPTIONS= PERL "Build perl bindings" on > .else > OPTIONS= PERL "Build perl bindings" off > .endif > > If WITH_PERL defined somewhere (pdflib-perl, make.conf or portconf), > the perl option should already be turned on by options framework. It > seems that a default-off perl option (line 4) is enough. From a functional point of view: yes, it's enough. From a user-experience point of view, if you install pdflib-perl I think you'll be confused if the PERL option is not selected. -- Alex Dupre