From nobody Thu Jun 18 04:40:02 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ggp1G6KJNz6jQ0H for ; Thu, 18 Jun 2026 04:40:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ggp1G548qz3p91 for ; Thu, 18 Jun 2026 04:40:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781757602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FYThF5BfSDFy3MwfjhGJVm0sEDXVGiXB8IEVc0Mzeng=; b=cTu52kL2Ovm8gRBlvo28nJ6hbekAN2gKc7aRICa9ORQIDCcddQFOTtHA9+s4SSJsPQVTVi JUNn/dQ5YkWAIaTPiCqmiIk0CN7rjI1/ycrHVUyvBBdWL2YK3w1EPw9pfIryNyL6/nhggL e5QoErSbV9QljiUTqzfjZv118HD1T6kidwXPIZBPJTOt4Heb86zrFNl/AGeXeGWkN5emCN MQZl14Bnzt56Wwz1KxTwWqE1bwvF20s9v39MBdCgG1pi49nZY86dnxCy7padgULGBGB841 1cogPk/G5AZz8/7yVlICiFalPSHk/1V+PzDnZdAdTx2+Lb/hssaarVfKZjt0FA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781757602; a=rsa-sha256; cv=none; b=WhDlL2xJE5mg0YuWmdV3ehmWVHDJOLcu2vZvAi4x8uGNvAuDhuN08LMEBKNPrpNQZG+TpA iOo8ji2TrFAsWRnE7TNjCzsKZJYbK3qJoEQsbZMKvvJAlQJEqDDvTv0TQgMY7k9DNOfZK+ db0agE+dCsXzPh3DD0UdjoLK/jlo1DGDm+F4eLHCSfQZl+6SjVU4rd7mdbGAtRo/P1CwNW DDAxeuL9qOeaRjLhjAmlqK885GeIcPjqFQBLhoPZYyomr1Cvg7LXaSICHdkWs9jOlUtlMo 1szYRrv12OA9l8OO0g1bWZ/5HB2f1wHsmhax2rLaOxiUNg5Keo8adzr4JFsPEg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781757602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FYThF5BfSDFy3MwfjhGJVm0sEDXVGiXB8IEVc0Mzeng=; b=EVTZ2VFtGJ6PGkAWM1wNKsr5gSPjnTd8vZfQVkpbQxfOr0DpjyweCvONE/kaUZGh8Ph7p1 U03wfpX1caJowefwdwIRK1OQIKIAIMCS9DBoTPBHZJThKZ2AzUi/JK0aETKkLbpmvbMa0/ CXtOYbLC3kX97cLolUhcHnWSsf+8srmA2SKMuaCL9TT8sj/SnsosxJUtaZ+FrBf9bLIPzo N7JMe9DqsUVCl/R7sc1pxEGO0Eof2ypR4h4IbGDh0lsi1oVgL7QgJgFtUzd8lQjVMxb8tW 885rQN7D6sYm1q0cbA6malivpjgpEixlvsiuWL8lFn019nH74cFNsqhKfQehMg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4ggp1G3H9MzkG4 for ; Thu, 18 Jun 2026 04:40:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1dcec by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 18 Jun 2026 04:40:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: 6d4fafc0f69e - stable/15 - ntsync(9): do not double-free obj when finstall() failed List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 6d4fafc0f69e14c8aeb5aaf28095d42b6da55aed Auto-Submitted: auto-generated Date: Thu, 18 Jun 2026 04:40:02 +0000 Message-Id: <6a3376a2.1dcec.7235b665@gitrepo.freebsd.org> The branch stable/15 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=6d4fafc0f69e14c8aeb5aaf28095d42b6da55aed commit 6d4fafc0f69e14c8aeb5aaf28095d42b6da55aed Author: Konstantin Belousov AuthorDate: 2026-06-15 04:41:53 +0000 Commit: Konstantin Belousov CommitDate: 2026-06-17 18:24:58 +0000 ntsync(9): do not double-free obj when finstall() failed (cherry picked from commit 1491ab351b45b1c727eeed40027f7b5074b19ff5) --- sys/dev/ntsync/ntsync.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/ntsync/ntsync.c b/sys/dev/ntsync/ntsync.c index 5fba9775be0e..2dec2f68aa80 100644 --- a/sys/dev/ntsync/ntsync.c +++ b/sys/dev/ntsync/ntsync.c @@ -297,6 +297,7 @@ ntsync_create_obj(struct ntsync_obj *obj, struct fileops *fops, finit(fp, FREAD | FWRITE, DTYPE_NTSYNC, obj, fops); error = finstall(td, fp, &fd, 0, NULL); if (error != 0) { + finit(fp, FREAD | FWRITE, DTYPE_NONE, NULL, &badfileops); NTSYNC_PRIV_LOCK(priv); MPASS(priv->objs_cnt > 0); priv->objs_cnt--;