From nobody Sat Dec 17 08:51:46 2022 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NZ08G4gNWzZkR5 for ; Sat, 17 Dec 2022 08:51:58 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NZ08G01Nzz44Gd; Sat, 17 Dec 2022 08:51:57 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1671267109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yXfg6MJYK2uevfpzAvmnMnXGkFtpMUWsFNW60FjP2XY=; b=G8yRgF4/2pjIaOrqw10Oc+JnxdL31lxxdQpIQaKcp7x/QrJQgNDPir6rw7VKe/UXkaf8h9 jWID4PG/RnTgLJdpzXjalRGFI4bI0r20+crEZU6cWIkA4FBUNbZHj7+JhRPVyVsJpvZ4L0 ZN9TkKCKMEA/gWFfK6foEFd0GxEWUqo= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 1365cb98 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 17 Dec 2022 08:51:49 +0000 (UTC) Date: Sat, 17 Dec 2022 09:51:46 +0100 From: Emmanuel Vadot To: Jonathan Vasquez Cc: unkadoug@gmail.com, freebsd-stable@freebsd.org, dougm@freebsd.org Subject: Re: stable/13 - amdgpu broken with n253286-d8a88ec38149 Message-Id: <20221217095146.ab7461adab9cc981d5db4b1d@bidouilliste.com> In-Reply-To: References: <5D2B4EDD-E277-4314-9CA9-CEACC67658DE@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4NZ08G01Nzz44Gd X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Hello Jonathan, On Sat, 17 Dec 2022 02:42:42 +0000 Jonathan Vasquez wrote: > Oh, I think I understand a bit better what you meant. Yup, after I found = which stable/13 commit was problematic, I compiled HEAD~1 which still works= , then I recompiled drm-510-kmod and it's working now. But I still wanted t= o report it since I'm guessing there will need to be some tweaks made to dr= m-510-kmod so that it works again with the latest stable/13. There is no tweaks to be done for drm-kmod. In fact in the last two days to commits who broke KBI between 13.1 and stable/13 were taken care of (one I've reverted and the other one being the one Doug fixed). Yes it's a bit unfortunate for stable/13 users that we broke KBI a few times and that you needed to recompile drm-kmod for it to work but what I want is when 13.2 is released users don't have to recompile the ports and can safely upgrade their machines (as the drm-510-kmod port will be compiled on 13.1 for 3 months). Cheers, > Jonathan Vasquez > PGP: 34DA 858C 1447 509E C77A D49F FB85 90B7 C4CA 5279 > Sent with ProtonMail Secure Email >=20 > ------- Original Message ------- > On Friday, December 16th, 2022 at 21:31, Jonathan Vasquez = wrote: >=20 > > Hey Doug, > > > > Not a problem. I actually did clean rebuilds of everything, including p= ulling the latest ports and cleanly reinstalling drm-510-kmod and gpu-firmw= are-amd-kmod. But it still failed. > > > > Jonathan Vasquez > > PGP: 34DA 858C 1447 509E C77A D49F FB85 90B7 C4CA 5279 > > Sent with ProtonMail Secure Email > > > > Sent from Proton Mail mobile > > > > -------- Original Message -------- > > On Dec 16, 2022, 21:05, Doug Moore < unkadoug@gmail.com> wrote: > > > >> Short answer - try rebuilding kmod from scratch. > >> > >> Long answer - I moved into stable/13 changes from main that changed so= me binary-level representations. One who found that the kmod he built befor= e those changes no longer worked pointed out my error. So I made a change t= o stable/13 recently to restore the original representations, and satisfied= that person?s complaint. But, someone who built kmod recently will find th= ings broken, the way the original fellow did. I can only apologize and ask = you to rebuild non-kernel stuff based on the stable/13 of more than a day a= go. I hadn?t considered the impact of my changes on non-kernel code. > >> Doug > >> > >> Sent from my iPad > >> > >>> On Dec 16, 2022, at 6:50 PM, Jonathan Vasquez wrote: > >> > >>> ? > >>> Hey all, > >>> > >>> it seems that my AMD Radeon 6900 XT doesn't load the amdgpu properly = anymore. The machine will crash immediately upon load. After a bisect, I fo= und the posted commit. This card uses the sienna_cichlid? flavor for gpu-fi= rmware-amd-kmod. > >>> > >>> commit d8a88ec381498f5942403088d28ee325b92e9a78 > >>> Author: Doug Moore > >>> Date: Fri Dec 16 03:15:28 2022 -0600 > >>> > >>> rb_tree: restore binary compat w/ 13 > >>> > >>> A change to RB_COLOR_INSERT, when merged into stable/13, broke binary > >>> compatibility. For 13, call the new function RB_DO_COLOR_INSERT, and > >>> restore the old function with the original name and parameters. Define > >>> RB_COLOR_INSERT in tree.h, and remove changes to the linux rbtree > >>> header. > >>> > >>> Another change altered the order of pointers in the RB_ENTRY struct. > >>> For 13, restore the original order. > >>> > >>> Reported by: manu > >>> Reviewed by: hselasky > >>> Tested by: manu > >>> Differential Revision: https://reviews.freebsd.org/D37716 > >>> > >>> sys/compat/linuxkpi/common/include/linux/rbtree.h | 11 ++---- > >>> sys/sys/tree.h | 46 ++++++++++++++++------- > >>> > >>> Jonathan Vasquez > >>> PGP: 34DA 858C 1447 509E C77A D49F FB85 90B7 C4CA 5279 > >>> Sent with ProtonMail Secure Email --=20 Emmanuel Vadot