From owner-svn-ports-all@FreeBSD.ORG Mon Sep 17 17:47:17 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE4D01065670 for ; Mon, 17 Sep 2012 17:47:16 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CF3898FC08 for ; Mon, 17 Sep 2012 17:47:16 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q8HHlGZV067018 for ; Mon, 17 Sep 2012 17:47:16 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q8HHlGjE067015 for svn-ports-all@freebsd.org; Mon, 17 Sep 2012 17:47:16 GMT (envelope-from bdrewery) Received: (qmail 50600 invoked from network); 17 Sep 2012 12:47:14 -0500 Received: from unknown (HELO ?192.168.0.74?) (freebsd@shatow.net@74.94.87.209) by sweb.xzibition.com with ESMTPA; 17 Sep 2012 12:47:14 -0500 Message-ID: <50576222.90100@FreeBSD.org> Date: Mon, 17 Sep 2012 12:47:14 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120824 Thunderbird/15.0 MIME-Version: 1.0 To: Doug Barton References: <201209171722.q8HHMxH8058790@svn.freebsd.org> <50575D5F.5070300@FreeBSD.org> In-Reply-To: <50575D5F.5070300@FreeBSD.org> X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r304413 - head X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2012 17:47:17 -0000 On 9/17/2012 12:26 PM, Doug Barton wrote: > On 09/17/2012 10:22, Bryan Drewery wrote: >> - Use 'make -C' here [2] > > The general consensus has been that 'make -C' is both a bit too clever, > and sometimes doesn't work. What's wrong with using the simple command > that is guaranteed to work? > > Doug > I argued the same for not having it originally. However, I've been told it only "did not work" in <=4.x. I've yet to have a problem with it, we use it all over the place in scripts, ie make -C /usr/ports... -V VAR, without issue. If it does not work, it should be fixed or removed. Bryan