From owner-freebsd-current@FreeBSD.ORG  Thu Jul  3 14:05:38 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E273D1065673
	for <current@freebsd.org>; Thu,  3 Jul 2008 14:05:38 +0000 (UTC)
	(envelope-from luigi@onelab2.iet.unipi.it)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.9.129])
	by mx1.freebsd.org (Postfix) with ESMTP id 9E5D38FC15
	for <current@freebsd.org>; Thu,  3 Jul 2008 14:05:38 +0000 (UTC)
	(envelope-from luigi@onelab2.iet.unipi.it)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
	id C69B473087; Thu,  3 Jul 2008 16:07:19 +0200 (CEST)
Date: Thu, 3 Jul 2008 16:07:19 +0200
From: Luigi Rizzo <rizzo@icir.org>
To: current@freebsd.org
Message-ID: <20080703140719.GA72315@onelab2.iet.unipi.it>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.2.3i
X-Mailman-Approved-At: Thu, 03 Jul 2008 14:20:17 +0000
Cc: usb@freebsd.org
Subject: may I commit this small umodem patch ?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Jul 2008 14:05:39 -0000

There was a discussion back in september about adding
support for basic CDC tty devices in umodem.c.
This lets you talk to a number of usb devices built around
microcontrollers (e.g. Atmel), and puts us on par with
Linux and Windows in terms of supporting these devices.

Because this simply requires the small patch below to the
probe/attach routine, so if there are no objections I plan to add
this to the system (CURRENT then RELENG_7 and RELENG_6) in the next
few days.

> Index: umodem.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/usb/umodem.c,v
> retrieving revision 1.57
> diff -u -r1.57 umodem.c
> --- umodem.c	31 Jan 2005 13:58:10 -0000	1.57
> +++ umodem.c	20 Aug 2006 17:05:34 -0000
> @@ -256,6 +260,15 @@
>  	    id->bInterfaceProtocol == UIPROTO_CDC_AT)
>  		ret = UMATCH_IFACECLASS_IFACESUBCLASS_IFACEPROTO;
>  
> +#if 1
> +	if (ret == UMATCH_NONE &&
> +	    id->bInterfaceClass == UICLASS_CDC_DATA &&
> +	    id->bInterfaceSubClass == UISUBCLASS_DATA &&
> +	    id->bInterfaceProtocol == 0x00)
> +		ret = UMATCH_IFACECLASS_IFACESUBCLASS_IFACEPROTO;
> +		return ret;
> +#endif
> +
>  	if (ret == UMATCH_NONE)
>  		return (ret);

cheers
luigi