From owner-freebsd-www@FreeBSD.ORG Thu Sep 1 20:58:18 2005 Return-Path: X-Original-To: www@freebsd.org Delivered-To: freebsd-www@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E857816A41F for ; Thu, 1 Sep 2005 20:58:18 +0000 (GMT) (envelope-from jcamou@opensea.mephis.org) Received: from sccrmhc12.comcast.net (sccrmhc12.comcast.net [204.127.202.56]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D77943D48 for ; Thu, 1 Sep 2005 20:58:17 +0000 (GMT) (envelope-from jcamou@opensea.mephis.org) Received: from opensea.mephis.org ([69.242.232.11]) by comcast.net (sccrmhc12) with ESMTP id <20050901205816012002cnm3e>; Thu, 1 Sep 2005 20:58:16 +0000 Received: from opensea.mephis.org (localhost [127.0.0.1]) by opensea.mephis.org (8.13.3/8.13.3) with ESMTP id j81L2EoN007486; Thu, 1 Sep 2005 14:02:15 -0700 (MST) (envelope-from jcamou@opensea.mephis.org) Received: (from jcamou@localhost) by opensea.mephis.org (8.13.3/8.13.3/Submit) id j81L2D6W007485; Thu, 1 Sep 2005 14:02:13 -0700 (MST) (envelope-from jcamou) Date: Thu, 1 Sep 2005 14:02:13 -0700 From: "Jesus R. Camou" To: Daniel Gerzo Message-ID: <20050901210213.GK1054@opensea.mephis.org> References: <1029392505.20050901194124@rulez.sk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1029392505.20050901194124@rulez.sk> User-Agent: Mutt/1.4.2.1i Cc: www@freebsd.org Subject: Re: query-pr-summary.cgi rework X-BeenThere: freebsd-www@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: jcamou@freebsd.org List-Id: FreeBSD Project Webmasters List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Sep 2005 20:58:19 -0000 On Thu, Sep 01, 2005 at 07:41:24PM +0200, Daniel Gerzo wrote: > Hello www, > > I would like to announce my work to you and get some feedback. If > you feel that the patch is okay and doesn't need any more changes, > I would like to send PR and get it commited :-) > > Changes to the query-pr-summary.cgi script include: > > o) rewritten code so it's more readable now, replaced some " with '. > o) make the html output html valid. > o) the minor feature I've added is that the PRs in the html output > are now splitted according to the each PR's state and each state > has it's own color, so it's easier now to determinate the PR's > state on the web page. This has been done by adding a few css > classes, so if colors aren't meeting our needs, it is pretty > easy to modify them. > > This work was already tested by remko@ and it seems to work. The > affects of my work are visible at for example: > > http://people.freebsd.org/~remko/danger-test/query-pr-summary2.cgi?category=conf > > and the patch is available at: > > http://danger.rulez.sk/query-pr-summary.diff > > Also, I would like to say thanks to remko@, who was really nice to > me and helped me with testing, since I had no access to the PR > database. I like the way it looks. It's not a bad idea to send that pr. :-) -- Jesus R. Camou - jcamou@FreeBSD.org