From nobody Thu May 22 08:02:24 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b313m498Pz5w3fY; Thu, 22 May 2025 08:02:28 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b313m3jZSz497p; Thu, 22 May 2025 08:02:28 +0000 (UTC) (envelope-from avg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747900948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kDD09aDLo5BjBMd9i+eUXw7e2OWrCxC3M55PrTK7SpM=; b=svxw9v6LILuw9FrWYJk1QR3F7gz/ZFb2PByI49F0HuHyh07oueeyxw24R+9HnDNQfnlfDk uIMGtMZ1tyh5ibG20O8U3UKX031jMTU6S0f9oCMt1MFMp8qmeOVX7rakUlNrzYz5OqRNtV hdYGwgD3bHgDzuquIo9mHmJSWpOmVPj8NsQNMOjmps9OUBfT/V7qPIqhD2ZP5ohoNRVhNV kv0BCNVnQGBWjzcbEjmjBWHFlSXhT6YJb5LUM1cRotRofl03IGKQ/2UEEufl4cTlvrCmfD ZKgkrTUOOfqvTN8NoUlM3BJVsYaRFh6A+LBtPf3iCG0okSuk6hWtRcFCZlFXsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747900948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kDD09aDLo5BjBMd9i+eUXw7e2OWrCxC3M55PrTK7SpM=; b=HUNIKt1c9zJmpfJf6kOj14JzMsqPRNCDmQx6xmgjpuzB5muZrKj5USUj5OOpGcWHHpzr/i gqxZcYRaGl1cUhZRZcKadk2UVbm9Hg4vQxovufyuKHaeQKrqBmtqtnptJFWlvw17xr5HN0 dXZtk7aJEix+hszizWQ2dYp+1DlEg6rzB67KGSBeI01EXCz6ROGJKa6Whs4fsuj4eJKaC3 za2ZrbBz5gG0mGN5fqLHA6M2dKObiknfv2dKt2MT3ByHD8zhygnunNDBb5IFHavPEUQ/Oa wPGwr9kxBjNtMsY9BwXZ0Fy0aVlbCOxDoy6ioOqakZusSNd/bNXKvYBWXqrvfQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747900948; a=rsa-sha256; cv=none; b=MpEdiKmx6yKSJM99nlwIFuSRb6DGSzlWQOfYs4Dyn2dCTQA84U4cCEmW9aTOP0inL9FkX9 ZjJotyN5+F7bu45BjNAaiwZYld+tc6QT/1msye6UrGC10/KKKKtyNC6RT5cS4C+6A4Cd/c WZlnGfWlEWlZv3SMozFvq1E958Y4CuaDJS+sxduUMpMFI5t4Rp34k3Y1doEMneJcY4acRw ik7q8g+KebSQHxgzrx5Ri9YQgyZop7U9dyhYeADELe7YJGzRbfLYOVhTWIav1aoNxeTcZP rN0CqWfpA+9lLeEBfRk7bOep/NFqNpPe6zq/8jBA/JVN+xWliX98dUMXKyA1Eg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [192.168.0.88] (unknown [93.188.39.137]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: avg/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4b313l65JGzlBT; Thu, 22 May 2025 08:02:27 +0000 (UTC) (envelope-from avg@FreeBSD.org) Message-ID: Date: Thu, 22 May 2025 11:02:24 +0300 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Andriy Gapon Subject: Re: 0d2fd5b99c95 - main - ns8250: use LSR_THRE instead of LSR_TEMT for checking tx flush To: mmel@FreeBSD.org, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202505201457.54KEvD1r053951@gitrepo.freebsd.org> <1a11f640-be62-4f4e-b537-70806ac54831@FreeBSD.org> <37BF51C0-C631-493F-B3AF-3AA9FC32551B@panasas.com> <13b1bbfe-4a60-4c4a-aa4e-ed168cb1286a@FreeBSD.org> Content-Language: en-US Autocrypt: addr=avg@FreeBSD.org; keydata= xsDNBGcKrHEBDADRvwQOK0b/yo4ys5cs6bOQMhEh4xtfbaZ/CU00cpPgUip3sOZCdrtMWlRC g25z97prxE9pKueZi+HXDhIPpa9xl14ghqF4oYScuJ1i18HyiOH2y5Q3Vv/TtFiSzicd3EAu QgS3jVidpgDSPDdj2Yz3UxYpZ+PuFl6nOnvCvqOFcjUlzKCyPaiN2b86l1Nscmhnc+zQ/faB erUOEFEDQbWMA5YfXi8HrbeR16hfRfGt7E0aMDlIj9FIPIq71UWMN9CimPgs4+rbNr1MAlLa z4GxSDhVYZEY5rqtCzr+PLXboRQWnaUwXl0/biw9enf17NHdYv1SNAFTX2eC4dZ3qBVI74dS PgNprm+PMfz+6Hhs/dAv+Nan5nVhg3EFIjYTiy0MnjMSq8uI0v0ykpAGAcJJ5xl6d23aLxgN 6f0z6pJRCO0hGPgU7UzvFD0MxJxmbzqdT1R51KDan1oD41b+tjl2LMBuCDCoB0U44Pu0zLdp xMfFTxCXtwIYKIUxwd28jwMAEQEAAc0eQW5kcml5IEdhcG9uIDxhdmdARnJlZUJTRC5vcmc+ wsENBBMBCAA3FiEEmXvSmjiQFHPVOpLnzDOt5NLj67sFAmcKrHEFCQeEzgACGwMECwkIBwUV CAkKCwUWAgMBAAAKCRDMM63k0uPru5tSDACFK15LLbq89RSQ6QMnjiIm1t/wYJyumb519MHu Dhzxx1lbr8oghf0RHtF6kYRLQPaW2VdToi74pRobd3CN4bhZKDLSL6WfTn17RfavDjL6Njwp KBo30CkOeYKWq1mDmo0xEoQj8cc7ybEZnus+YScZOpj8Ti4EFwhRt6SHer7YDb161IHKL8m4 MsCxpFSGEjbKj8Iul3Ri/fTOO8w14ivcuEEQIvJt4/+4YV5Az8G23wKzL/3aJ7SOT3oYGmR9 atBTmVO3DlODjM+rZLegd8SfLSPTcBTHspWE5duemIzZbEX3BP77r3Qx4Fo5Tkit3bG1XVar yPQato+sFGFEGifdE9USBQoAoOaaeZevwAWjDU0TIuCT0CUe0sKtQuNP4LRq0n9EEHOXBu9a CfdMhFUSkAZnuE7miSVwgPvoVNJ1stA37EXLN/sVsWik7wslTQ5vF81VpdGFiwoQPOe2XEKh ogcwGSnXbwv1gD4x+Gz/7Y+kFyr1NY+4/nSaeXVcS2fOwM0EZwqscgEMAMQTe6ypAmQe/TFO HqKD2hfFKdksTptKi6uEh8xIwct8G/0FBldDWXo9eu8CGr/ZrDg0/bAwJxbaLRQCMH19Gq2Y hLvZ1QK5GQJVzZKcqfxbF2LiDUTs6WkdOBIhGpdDy7p1xFrvqCGCtNFYHuGYm067EozibBSF BWAPstKu2FQuVHZNMOfs7p3OIz3Yfqu9woXDeg3/8G2qVQJINe+8EwXKlhgh4CyDbq7nAZoA kIu1SE9z9u3WI5mcNy/0dFmVUsFxBqRC3ewbvzie8tKyZ9yFOlaZPT0Y4nRBXQTI3mLZ8zQ8 mtrWK5OOmrJ02kdeO9RBXe+OMaUUWMf92ZIoBFb4HP6N+B+4N1y1OwULousfl7JRoYxA4MRL ls7E2sSoJvrEBTJB3Pc34xu8rsJ1A5V3NgN6djX8yEZYpTRkcmrBeWy/ofDqZPVqneAx0LRm eldDS9msXDW4KXODyPZ+9unvmHAcoH0xaBYaSH44CDZDQDg4LNcmbOvuu1TEXBJhjQARAQAB wsD8BBgBCAAmFiEEmXvSmjiQFHPVOpLnzDOt5NLj67sFAmcKrHMFCQeEzgACGwwACgkQzDOt 5NLj67sUCAv5AXqgWnYN9EblapMbZjkiqL8pZQ0GNqh+Pg9FwbyULxjtRTO6rD4D0IxizByb ef+neeUNyYlagt5nfKMysEr0SU/gHKCi8vyTF/63ukMrGUNGmJJxrndl5ZYKC6j6eX7twrZF L1Uvlmn6FnQ22red5kHO93fDjG4zaDIZvHfwj7kzjZ4tpC7Byinf88s14mdZeScc0PnU2hj4 UGYju/wg2FF4YxaZYhcmdTiRYY0Wx85XSMZv19pnn78sadEuRvfRd4JTmw++j1xGXeqQGWzz /CTG5/Ex9GAkQ02hZbmi236byDXoet4G8TEyOph9QFVkV9bNd0jQZaFZPGEj4PSPUYGAF7s5 xJaNGgctC3aZ7WjEv1FBoo44XCU4xcjJ1wZQUrHxRhx6TW0Jtcl0U9qfKFW30TSPo6RyiXuj X4ltWKAtjoXB8nUmEJckaz7IRu2b4pXDeazZuz5JBygUs10yJjDxh2vFQZo0KaBAPx9MZlPn gpPTjT15L8xGftEjQXF6 In-Reply-To: <13b1bbfe-4a60-4c4a-aa4e-ed168cb1286a@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/05/2025 09:37, mmel@FreeBSD.org wrote: > I wrote: >> Maybe I don't understand the code, but UART_FLUSH_RECEIVER in ns8250_bus_attach >> looks strange to me. It's one thing to flush data while in the loop-back mode, >> but I think that in ns8250_bus_attach the hardware is fully set up to receive >> data from the outside world. So, how can we hope to drain all of it and to >> reliably detect whether FIFO flushing works. I mean that something on the other >> end could be continuously transmitting. >> > I'm not sure if I understand you exactly, but in loop-back mode the RX input is > internally connected to the TX output (i.e. disconnected from the outside > world). So from that perspective, the FIFO detection and flush seems fine to me. Right. Loop-back mode is used in probe, but in attach the UART is in normal mode as far as I can tell. -- Andriy Gapon