From owner-svn-ports-all@FreeBSD.ORG Sun Jun 14 19:03:45 2015 Return-Path: Delivered-To: svn-ports-all@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D2BE8242; Sun, 14 Jun 2015 19:03:45 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-lb0-x231.google.com (mail-lb0-x231.google.com [IPv6:2a00:1450:4010:c04::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 583CCCD7; Sun, 14 Jun 2015 19:03:45 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: by lbbqq2 with SMTP id qq2so41903508lbb.3; Sun, 14 Jun 2015 12:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=aBy+unoq93et+fSEEyQP2jl9Vq0lPdoBfbIZRfGJnwc=; b=P1OcWv+yBHyEfz9O1Za6jFrcBYbGjvp4iSNHywn5i3JaNQqlXBA+hMbDifnLnnj2bw 0mdU1L5Q4K4K/VDABHQzytP+HaYySwgR4u+MEftG2RddmQZRmMiXjL99GcbZm8G3mhaU 0KargvFV/Pb5rB0hhJPU6qIH/xk7H5AGdwq2dYI/Y6UX7yN8lQIwq+Ub8a98wIkQPKeW 66nwiQ+2wFmyTxVyCPA5hNDUlENdcRNoKcoLxh2cgiucUdUixLIKr46OZ5ivdE/bzqle SpiQ9ayTsaII8OcQntHiB065Q4P1cLcdKSZq1dV7g0F01MyuHcShf2y7UUNZKxNoGQ4s v15Q== MIME-Version: 1.0 X-Received: by 10.152.29.69 with SMTP id i5mr6006115lah.6.1434308623465; Sun, 14 Jun 2015 12:03:43 -0700 (PDT) Sender: bsdkaffee@gmail.com Received: by 10.25.201.71 with HTTP; Sun, 14 Jun 2015 12:03:43 -0700 (PDT) In-Reply-To: <20150614180031.0a62314f@kalimero.tijl.coosemans.org> References: <201506141528.t5EFS3Ou060777@svn.freebsd.org> <20150614180031.0a62314f@kalimero.tijl.coosemans.org> Date: Sun, 14 Jun 2015 15:03:43 -0400 X-Google-Sender-Auth: SxTXHKAiEGb19Gon5vpX5bTw768 Message-ID: Subject: Re: svn commit: r389642 - in head/graphics: opencv opencv-core opencv-java py-opencv From: "Jason E. Hale" To: Tijl Coosemans Cc: ports-committers , "svn-ports-all@freebsd.org" , "svn-ports-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2015 19:03:45 -0000 On Sun, Jun 14, 2015 at 12:00 PM, Tijl Coosemans wrote: > On Sun, 14 Jun 2015 15:28:03 +0000 (UTC) "Jason E. Hale" wrote: >> Author: jhale >> Date: Sun Jun 14 15:28:03 2015 >> New Revision: 389642 >> URL: https://svnweb.freebsd.org/changeset/ports/389642 >> >> Log: >> - Add SIMD option to specifically disable CPU optimizations and prevent crashes >> with ffmpeg on processors that do not support SSE instructions. OFF by >> default for package building, ON with autodetect for ports to keep with >> POLA. [1][2] >> - Bump PORTREVISION on all opencv ports >> >> PR: 199715 [1], 200234 [2] >> Submitted by: Randy Westlund [1], sasamotikomi@gmail.com [2] >> >> Modified: >> head/graphics/opencv-core/Makefile >> head/graphics/opencv-java/Makefile >> head/graphics/opencv/Makefile >> head/graphics/py-opencv/Makefile >> >> Modified: head/graphics/opencv-core/Makefile >> ============================================================================== >> --- head/graphics/opencv-core/Makefile Sun Jun 14 15:15:42 2015 (r389641) >> +++ head/graphics/opencv-core/Makefile Sun Jun 14 15:28:03 2015 (r389642) >> @@ -1,7 +1,7 @@ >> # Created by: Martin Matuska >> # $FreeBSD$ >> >> -PORTREVISION= 2 >> +PORTREVISION= 3 >> PKGNAMESUFFIX= -${OCV_SLAVE} >> >> COMMENT= OpenCV core libraries >> >> Modified: head/graphics/opencv-java/Makefile >> ============================================================================== >> --- head/graphics/opencv-java/Makefile Sun Jun 14 15:15:42 2015 (r389641) >> +++ head/graphics/opencv-java/Makefile Sun Jun 14 15:28:03 2015 (r389642) >> @@ -1,6 +1,6 @@ >> # $FreeBSD$ >> >> -PORTREVISION= 1 >> +PORTREVISION= 2 >> CATEGORIES= graphics java >> PKGNAMESUFFIX= -${OCV_SLAVE} >> >> >> Modified: head/graphics/opencv/Makefile >> ============================================================================== >> --- head/graphics/opencv/Makefile Sun Jun 14 15:15:42 2015 (r389641) >> +++ head/graphics/opencv/Makefile Sun Jun 14 15:28:03 2015 (r389642) >> @@ -3,7 +3,7 @@ >> >> PORTNAME?= opencv >> PORTVERSION= 2.4.9 >> -PORTREVISION?= 4 >> +PORTREVISION?= 5 >> CATEGORIES= graphics >> MASTER_SITES= SF/${PORTNAME}library/${PORTNAME}-unix/${PORTVERSION} >> >> @@ -42,7 +42,7 @@ OCV_NONFREE_MODS= nonfree >> OCV_JAVA_MODS= java >> OCV_PYTHON_MODS= python >> >> -OPTIONS_DEFINE= DC1394 EXAMPLES NONFREE OPENGL >> +OPTIONS_DEFINE= DC1394 EXAMPLES NONFREE OPENGL SIMD >> OPTIONS_GROUP= IMAGE PERFORMANCE VIDEO >> OPTIONS_GROUP_IMAGE= JASPER JPEG OPENEXR PNG TIFF >> OPTIONS_GROUP_PERFORMANCE= EIGEN3 TBB >> @@ -50,6 +50,9 @@ OPTIONS_GROUP_VIDEO= FFMPEG GSTREAMER V4 >> OPTIONS_RADIO= GUI >> OPTIONS_RADIO_GUI= GTK2 QT4 >> OPTIONS_DEFAULT= EIGEN3 JASPER JPEG PNG TIFF V4L >> +.if !defined(PACKAGE_BUILDING) >> +OPTIONS_DEFAULT= SIMD >> +.endif > > This also disables SSE/SSE2 in the amd64 package. You can just remove > this though. The package builders will do the right thing. There are probably a few amd64 processors that don't support SSE3, although all should support SSE and SSE2. Trying to work all of that out so certain packages have a bare minimum of optimizations is a bit more work. It was easier to just disable it all because it will just end up autodetecting whatever the package builder supports and making a package that might not work on some systems. When I add in SSSE3, SSE41, and SSE42 support later, it will be even more of a headache than it's worth.