From owner-svn-src-head@freebsd.org Sun Mar 19 00:26:05 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59F4AD0843B for ; Sun, 19 Mar 2017 00:26:05 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E010F1FDB for ; Sun, 19 Mar 2017 00:26:04 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 9ad6c8df-0c3a-11e7-b96d-2378c10e3beb X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id 9ad6c8df-0c3a-11e7-b96d-2378c10e3beb; Sun, 19 Mar 2017 00:25:51 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v2J0PodW012525; Sat, 18 Mar 2017 18:25:50 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1489883150.40576.222.camel@freebsd.org> Subject: Re: svn commit: r315522 - in head: contrib/binutils/ld/emulparams sys/conf From: Ian Lepore To: Ed Maste , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sat, 18 Mar 2017 18:25:50 -0600 In-Reply-To: <201703190022.v2J0MDhq015941@repo.freebsd.org> References: <201703190022.v2J0MDhq015941@repo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Mar 2017 00:26:05 -0000 On Sun, 2017-03-19 at 00:22 +0000, Ed Maste wrote: > Author: emaste > Date: Sun Mar 19 00:22:13 2017 > New Revision: 315522 > URL: https://svnweb.freebsd.org/changeset/base/315522 > > Log: >   use INT3 instead of NOP for x86 binary padding >    >   We should never end up executing the inter-function padding, so we >   are better off faulting than silently carrying on to whatever > function >   happens to be next. >    >   Note that LLD will soon do this by default (although it currently > pads >   with zeros). >    >   Reviewed by: dim, kib >   MFC after: 1 month >   Sponsored by: The FreeBSD Foundation >   Differential Revision: https://reviews.freebsd.org/D10047 > > Modified: >   head/contrib/binutils/ld/emulparams/elf_i386.sh >   head/contrib/binutils/ld/emulparams/elf_x86_64.sh >   head/sys/conf/ldscript.amd64 >   head/sys/conf/ldscript.i386 > > Modified: head/contrib/binutils/ld/emulparams/elf_i386.sh > ===================================================================== > ========= > --- head/contrib/binutils/ld/emulparams/elf_i386.sh Sat Mar 18 > 23:59:50 2017 (r315521) > +++ head/contrib/binutils/ld/emulparams/elf_i386.sh Sun Mar 19 > 00:22:13 2017 (r315522) > @@ -6,7 +6,7 @@ COMMONPAGESIZE="CONSTANT (COMMONPAGESIZE >  NONPAGED_TEXT_START_ADDR=0x08048000 >  ARCH=i386 >  MACHINE= > -NOP=0x90909090 > +NOP=0xCCCCCCCC I have always wondered why the arm ldscript pads with 0x90.  I don't know if I feel any better now, knowing that it's because that's an x86 nop instruction. :) -- Ian