From owner-svn-src-all@FreeBSD.ORG Mon Nov 15 01:24:14 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1701B1065670; Mon, 15 Nov 2010 01:24:14 +0000 (UTC) (envelope-from lstewart@freebsd.org) Received: from lauren.room52.net (lauren.room52.net [210.50.193.198]) by mx1.freebsd.org (Postfix) with ESMTP id C91B78FC23; Mon, 15 Nov 2010 01:24:13 +0000 (UTC) Received: from lawrence1.loshell.room52.net (ppp59-167-184-191.static.internode.on.net [59.167.184.191]) by lauren.room52.net (Postfix) with ESMTPSA id 27B7B7E8A5; Mon, 15 Nov 2010 12:24:07 +1100 (EST) Message-ID: <4CE08BB6.1090304@freebsd.org> Date: Mon, 15 Nov 2010 12:24:06 +1100 From: Lawrence Stewart User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-AU; rv:1.9.2.9) Gecko/20101006 Lightning/1.0b2 Thunderbird/3.1.4 MIME-Version: 1.0 To: Mikolaj Golub References: <201011120641.oAC6fui3098584@svn.freebsd.org> <8662w17e90.fsf@kopusha.home.net> <4CDF3A58.6080505@freebsd.org> <86pqu8q6lb.fsf@kopusha.home.net> In-Reply-To: <86pqu8q6lb.fsf@kopusha.home.net> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on lauren.room52.net Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r215166 - in head: . sys/conf sys/netinet sys/netinet/cc sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2010 01:24:14 -0000 On 11/15/10 02:15, Mikolaj Golub wrote: > > On Sun, 14 Nov 2010 12:24:40 +1100 Lawrence Stewart wrote: > > LS> On 11/13/10 20:40, Mikolaj Golub wrote: > >> > >> On Fri, 12 Nov 2010 06:41:56 +0000 (UTC) Lawrence Stewart wrote: > >> > >> LS> Author: lstewart > >> LS> Date: Fri Nov 12 06:41:55 2010 > >> LS> New Revision: 215166 > >> LS> URL: http://svn.freebsd.org/changeset/base/215166 > >> > >> LS> Log: > >> LS> This commit marks the first formal contribution of the "Five New TCP Congestion > >> LS> Control Algorithms for FreeBSD" FreeBSD Foundation funded project. More details > >> LS> about the project are available at: http://caia.swin.edu.au/freebsd/5cc/ > >> > >> It looks like the code needs improvement to work with VIMAGE :-) > >> > >> options VIMAGE > >> > >> jail -i -c vnet persist path=/ > >> > >> panic: lock "cc_list" 0xc101c418 already initialized > >> [snip backtrace] > > LS> Would you mind testing the following patch? It fixes the panic for me. > > LS> http://people.freebsd.org/~lstewart/patches/5cc/modcc_vnetpanic_ccinit.patch > > With this patch the system hangs during the boot. Ctr-Alt-Esc to break into > ddb does not work. I am trying this under VirtualBox. I can't reproduce a hang, but please try this patch instead: http://people.freebsd.org/~lstewart/patches/5cc/modcc_vnetpanic_ccinit_v2.patch The previous patch had a bug, in that CC modules register with SI_ORDER_ANY in the same SI_SUB_PROTO_IFATTACHDOMAIN category as the CC framework's SYSINIT (which also ran with SI_ORDER_ANY). Therefore, there is a possibility an algo could have tried to register before the CC framework SYSINIT ran. To be honest though, I don't expect the updated patch will fix the hang. I would have expected a panic rather than a hang if you were seeing any complications due to the SYSINIT ordering because the algo registration would have attempted to use an uninitialised lock. I suspect your hang might be caused by something unrelated to the modular CC work, but let me know how you go. Cheers, Lawrence