From owner-svn-ports-all@FreeBSD.ORG Mon Nov 25 00:17:58 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 76E26ED5; Mon, 25 Nov 2013 00:17:58 +0000 (UTC) Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66]) by mx1.freebsd.org (Postfix) with ESMTP id 54CE32E3A; Mon, 25 Nov 2013 00:17:58 +0000 (UTC) Received: from [192.168.0.132] (vie-91-186-148-049.dsl.sil.at [91.186.148.49]) by ainaz.pair.com (Postfix) with ESMTPSA id B14463F465; Sun, 24 Nov 2013 19:17:53 -0500 (EST) Date: Mon, 25 Nov 2013 01:17:52 +0100 (CET) From: Gerald Pfeifer To: Mathieu Arnold Subject: Re: svn commit: r334796 - head/lang/gcc44 In-Reply-To: <0A5CE73D095D35D1C1F04476@atuin.in.mat.cc> Message-ID: References: <201311242311.rAONBAn2059702@svn.freebsd.org> <0A5CE73D095D35D1C1F04476@atuin.in.mat.cc> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Gerald Pfeifer , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Nov 2013 00:17:58 -0000 On Mon, 25 Nov 2013, Mathieu Arnold wrote: > | +PORTNAME= gcc47 > | PORTVERSION= 4.4.7 > > You meant gcc44, right ? Oops, right. All the full fledged testing unfortunately did not catch this kind of silly mistake. Thanks for raising it (and sorry for committing the fix so quickly that I failed to acknowledge that in the commit log). > BTW, why not use PKGNAMESUFFIX= 44 here (and in the other ports) so > that you don't have to add distname ? Bapt asked the same. :-) Below is what I responded. FWIW the description of UNIQUENAME does not mention PKGNAMESUFFIX either: # UNIQUENAME - A name for your port that is globally unique. By default, # this is set to ${LATEST_LINK} when LATEST_LINK is set, # and to ${PKGNAMEPREFIX}${PORTNAME} otherwise. Gerald ==== forwarded message ==== From: Gerald Pfeifer Date: Sun, 24 Nov 2013 22:21:19 +0100 (CET) Subject: Re: Package name collision : Looking at it from a distance, it felt a bit wrong to me to have PORTNAME for lang/gcc48 read gcc, not gcc48. And Mk/bsd.port.mk did not properly document that. The latter we can address, of course. Do you approve the patch below? Gerald Index: bsd.port.mk =================================================================== --- bsd.port.mk (revision 334791) +++ bsd.port.mk (working copy) @@ -68,9 +68,11 @@ # Do not define this in your Makefile. # PKGNAMEPREFIX - Prefix to specify that port is language-specific, etc. # Optional. -# PKGNAMESUFFIX - Suffix to specify compilation options. Optional. -# PKGVERSION - Always defined as -# ${PORTVERSION}. +# PKGNAMESUFFIX - Suffix to specify compilation options or a version +# designator (in case there are different versions of +# one port as is the case for Tcl). +# Optional. +# PKGVERSION - Always defined as ${PORTVERSION}. # Do not define this in your Makefile. # UNIQUENAME - A name for your port that is globally unique. By default, # this is set to ${LATEST_LINK} when LATEST_LINK is set,