From owner-freebsd-bugs@FreeBSD.ORG Wed Oct 5 11:20:19 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E05216A41F for ; Wed, 5 Oct 2005 11:20:19 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id F1D0343D48 for ; Wed, 5 Oct 2005 11:20:17 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j95BKHj4032302 for ; Wed, 5 Oct 2005 11:20:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j95BKHaa032301; Wed, 5 Oct 2005 11:20:17 GMT (envelope-from gnats) Resent-Date: Wed, 5 Oct 2005 11:20:17 GMT Resent-Message-Id: <200510051120.j95BKHaa032301@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Florent Thoumie Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B59516A41F; Wed, 5 Oct 2005 11:12:42 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 253AC43D46; Wed, 5 Oct 2005 11:12:41 +0000 (GMT) (envelope-from flz@xbsd.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id B5D7011769; Wed, 5 Oct 2005 13:12:39 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 18315-10; Wed, 5 Oct 2005 13:12:27 +0200 (CEST) Received: by smtp.xbsd.org (Postfix, from userid 2001) id 42F9E11598; Wed, 5 Oct 2005 13:12:26 +0200 (CEST) Message-Id: <20051005111226.42F9E11598@smtp.xbsd.org> Date: Wed, 5 Oct 2005 13:12:26 +0200 (CEST) From: Florent Thoumie To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: des@FreeBSD.org Subject: bin/86940: src/usr.bin/fetch - fix mirror mode (-m) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Florent Thoumie List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2005 11:20:19 -0000 >Number: 86940 >Category: bin >Synopsis: src/usr.bin/fetch - fix mirror mode (-m) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Oct 05 11:20:17 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Florent Thoumie >Release: FreeBSD 5.3-RELEASE i386 >Organization: Xbsd.org >Environment: System: FreeBSD srv1.xbsd.org 5.3-RELEASE FreeBSD 5.3-RELEASE #2: Wed Nov 24 16:35:34 CET 2004 root@gate.xbsd.org:/usr/src/sys/i386/compile/GATE i386 >Description: Mirror mode is actually not working because the size of local file is always set to -1. Maintainer (des@) CC'ed. >How-To-Repeat: Fetch one file, then try to re-fetch it with -am option. >Fix: --- fetch.c.diff begins here --- Index: fetch.c =================================================================== RCS file: /home/ncvs/src/usr.bin/fetch/fetch.c,v retrieving revision 1.75 diff -u -r1.75 fetch.c --- fetch.c 18 Nov 2004 12:01:30 -0000 1.75 +++ fetch.c 5 Oct 2005 11:04:10 -0000 @@ -418,7 +418,7 @@ sb.st_size = -1; if (!o_stdout) { r = stat(path, &sb); - if (r == 0 && r_flag && S_ISREG(sb.st_mode)) { + if (r == 0 && (r_flag || m_flag) && S_ISREG(sb.st_mode)) { url->offset = sb.st_size; } else { /* --- fetch.c.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: