From owner-freebsd-scsi@FreeBSD.ORG Fri Aug 31 18:30:37 2012 Return-Path: Delivered-To: scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5A6D5106566B; Fri, 31 Aug 2012 18:30:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 0116C8FC15; Fri, 31 Aug 2012 18:30:37 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 73AA7B91A; Fri, 31 Aug 2012 14:30:36 -0400 (EDT) From: John Baldwin To: scsi@freebsd.org Date: Fri, 31 Aug 2012 14:30:32 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p17; KDE/4.5.5; amd64; ; ) MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201208311430.32959.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 31 Aug 2012 14:30:36 -0400 (EDT) Cc: nyan@freebsd.org, non@freebsd.org Subject: [PATCH] Convert scsi_low from timeout(9) to callout(9) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2012 18:30:37 -0000 I have a patch to convert the scsi_low code from using the deprecated timeout(9) API to using callout(9) instead. Is anyone able to review or test this patch? I have not attempted to add locking to scsi_low as I don't know it well enough to know the various entry/exit points, etc. Also, it still has a lot of compat shims to work on NetBSD. I can't seem to find a scsi_low.c on NetBSD at all anymore. Do we still need NetBSD compat shims? If not, trimming those would make this code far more readable. http://www.FreeBSD.org/~jhb/patches/scsi_low_callout.patch -- John Baldwin