From owner-svn-src-all@freebsd.org Mon Dec 23 21:14:21 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3466D1D0753; Mon, 23 Dec 2019 21:14:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47hXCx0bcSz43ry; Mon, 23 Dec 2019 21:14:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 03452B28B; Mon, 23 Dec 2019 21:14:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f170.google.com with SMTP id w127so14545840qkb.11; Mon, 23 Dec 2019 13:14:20 -0800 (PST) X-Gm-Message-State: APjAAAVcVrB2q2kzsNBxh1Knp8Rxuvaqg77LEpWX4MHpje4v7iel0kUf DwDeKCsMRY27hBErBUXGLU2BAUxYHYdPns+NpJw= X-Google-Smtp-Source: APXvYqyO3QybKHVRVVsTTofS1madrxaun1zf0LrpoV/nYVTjCI6YCFdvFa+1EKSL71IOwVRwJdb55D4OYml4jdNFgfk= X-Received: by 2002:a37:4fd0:: with SMTP id d199mr28794997qkb.103.1577135660173; Mon, 23 Dec 2019 13:14:20 -0800 (PST) MIME-Version: 1.0 References: <201912201622.xBKGMEdl019516@repo.freebsd.org> In-Reply-To: <201912201622.xBKGMEdl019516@repo.freebsd.org> From: Kyle Evans Date: Mon, 23 Dec 2019 15:14:07 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r355936 - in head/sys: arm/broadcom/bcm2835 arm/freescale/imx arm/ti/am335x arm/versatile powerpc/ofw To: src-committers Cc: svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Dec 2019 21:14:21 -0000 On Fri, Dec 20, 2019 at 10:22 AM Kyle Evans wrote: > > Author: kevans > Date: Fri Dec 20 16:22:14 2019 > New Revision: 355936 > URL: https://svnweb.freebsd.org/changeset/base/355936 > > Log: > Kill off dummy kbd drivers > > As far as I can tell, these are an artifact of times when linker sets > couldn't be empty, otherwise the kernel build would fail due to unresolved > symbols. hselasky fixed this in r268138, and I've audited the kbd portions > to make sure nothing would blow up due to the empty linker set and > successfully compiled+ran a kernel with no keyboard support at all. > > Kill them off now since they're no longer required. > > MFC after: 1 week > It turns out that I missed one of these in ^/sys/dev/terasic/mtl/terasic_mtl_syscons.c, which has the following note that shows my analysis to be not inaccurate but incorrect: /* * XXXRW: For historical reasons, syscons can't register video consoles * without a keyboard implementation. Provide a dummy. */ As far as I can tell, this isn't the case anymore as sckbdprobe's return value is ignored and other references to the keyboard appear to be properly gated on sc->keyboard being valid. I only have a single machine that can run syscons, but I built a kernel with the same modifications to remove all of the keyboard drivers (-ukbd, kbdmux, hyperv) for that machine and encountered no problems in practice. I will proceed with removing the last dummy driver and MFC as scheduled. Thanks, Kyle Evans