From owner-freebsd-net@FreeBSD.ORG  Thu Feb 19 07:41:47 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2B9259B1
 for <freebsd-net@freebsd.org>; Thu, 19 Feb 2015 07:41:47 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 08BF7BC3
 for <freebsd-net@freebsd.org>; Thu, 19 Feb 2015 07:41:47 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t1J7fkIG084378
 for <freebsd-net@freebsd.org>; Thu, 19 Feb 2015 07:41:46 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J7fkZ3084366;
 Thu, 19 Feb 2015 07:41:46 GMT (envelope-from root)
Date: Thu, 19 Feb 2015 07:41:46 +0000
To: freebsd-net@freebsd.org
From: "pjd (Pawel Jakub Dawidek)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D1870: Add tests for nvlist_clone
Message-ID: <7fed1dc88c3e23fe64ea4dc97923e0a4@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1870: Add tests for nvlist_clone
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-vtlauz4uwe46gac4fu2j>
X-Phabricator-To: <PHID-USER-gsanmilqmw65clu6stb2>
X-Phabricator-Cc: <PHID-MLST-c3bj6mfydtlqmuethodc>
X-Phabricator-Cc: <PHID-USER-wdicbwgs4t3i2iwuuyrv>
In-Reply-To: <differential-rev-PHID-DREV-i4g3nn5qdjs7mg64g7t6-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-i4g3nn5qdjs7mg64g7t6-req@FreeBSD.org>
Thread-Index: YzdhNWFmMzVlZWYzY2IzNDlmMTM3MmY4ZjU0IFTlk7o=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Feb 2015 07:41:47 -0000

pjd added inline comments.

INLINE COMMENTS
  lib/libnv/tests/nv_tests.cc:324-331 Don't you want to test the clone here? If the values wre properly copied, if there is only one element, etc.? Now you are testing the source nvlist.

REVISION DETAIL
  https://reviews.freebsd.org/D1870

To: rstone, jfvogel
Cc: freebsd-net, pjd