Date: Fri, 28 Mar 2008 09:22:41 +0100 From: Roman Divacky <rdivacky@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: soralx@cydem.org, Pav Lucistnik <pav@FreeBSD.org>, freebsd-ports@FreeBSD.org Subject: Re: [patch] pkg_delete(1) speedup Message-ID: <20080328082241.GA48417@freebsd.org> In-Reply-To: <47EC5589.7070207@FreeBSD.org> References: <1206548309.78560.69.camel@pav.hide.vol.cz> <20080326201416.GA34807@freebsd.org> <47EC5589.7070207@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 27, 2008 at 07:18:49PM -0700, Doug Barton wrote: > Roman Divacky wrote: > >On Wed, Mar 26, 2008 at 05:18:29PM +0100, Pav Lucistnik wrote: > >>You might have noticed a thread on the mailing list called "ports system > >>woes". The submitter pointed out an inefficiency in pkg_delete routine, > >>that parses the whole /var/db/pkg over and over again for every > >>dependency of a package being removed. > >> > >>Attached is a patch by rdivacky that implements the idea of looking up > >>all the values in a single pass over /var/db/pkg content. > > > >I hacked a slightly better patch that coveres a part of pkg_add too.. > > > >please review/test on: > > > > www.vlakno.cz/~rdivacky/pkg_tools.patch > > > >comments, benchmarks more than welcome! > > A) this is massively cool stuff, thanks for taking this on. :) > B) you should probably do two versions of the patch, one with > style(9)-only changes, and one without. The former makes it much easier > to review the actual changes, and would speed your path to getting it in > the tree. there are 3 style-only changes in the patch.. 3 lines.. I didnt consider to make two separate patches for testing/review :) I'll do it if you insist.... thnx! roman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080328082241.GA48417>