From owner-cvs-all Tue Nov 2 20: 8:30 1999 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 75EE014C39; Tue, 2 Nov 1999 20:08:20 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from p83-ts5.syd2.zeta.org.au (beefcake.zeta.org.au [203.26.10.12]) by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id PAA28638; Wed, 3 Nov 1999 15:13:18 +1100 Date: Wed, 3 Nov 1999 15:08:10 +1100 (EST) From: Bruce Evans X-Sender: bde@alphplex.bde.org To: Archie Cobbs Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa spkr.c src/sys/kern subr_scanf.c src/sys/pc98/pc98 spkr.c src/sys/sys systm.h In-Reply-To: <199911030222.SAA75822@bubba.whistle.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Tue, 2 Nov 1999, Archie Cobbs wrote: > Bruce Evans writes: > > > Modified files: > > > sys/i386/isa spkr.c > > > sys/kern subr_scanf.c > > > sys/pc98/pc98 spkr.c > > > sys/sys systm.h > > > Log: > > > Consolidate some of the various ctype(3) macros in one location. > > > > That location should be libkern/ctype.h so that it doesn't pollute > > everything and so that libkern files can use the same #includes as > > their libc versions (INCLUDES+= -I$S/libkern). > > Yeah, I like that idea better too. > > I wasn't clear about doing that way though.. e.g., why was strtoul() > put inside kern/subr_scanf.c instead of libkern? I was following that > example. It was originally in sys/i386/i386/userconfig.c because it didn't seem likely at the time that it would be useful elsewhere, and the right way to maintain libkern was even less clearer than it is now. > Maybe strtoul() should be moved to a new file libkern/strtoul.c.. I told phk that it should have been put there. We also have a copy of strtol() in libstand. I think libstand should be under /sys and merged with libkern at the source level. It needs the same ctype hacks. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message