From owner-freebsd-current@FreeBSD.ORG Fri May 19 00:34:43 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8E74B16A421 for ; Fri, 19 May 2006 00:34:43 +0000 (UTC) (envelope-from rosti.bsd@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id E202143D45 for ; Fri, 19 May 2006 00:34:42 +0000 (GMT) (envelope-from rosti.bsd@gmail.com) Received: by ug-out-1314.google.com with SMTP id m3so626060uge for ; Thu, 18 May 2006 17:34:41 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type:content-transfer-encoding; b=Unx4r3sYfMNXguZYsyz8E6FoZmSwrh5eJXVj9jR2bHfnW+ZWSr39GdW7+vpqnMy3e8I9HtEhbehNoC9DiVeFrWd7m3lPCBVUxay/6CHIQHJZEkQJrU5jsy90h+5MRju7O+sZQqAQzchZwVUXSmt3o/sqF1GS+A3GGz3siri8CcU= Received: by 10.66.244.11 with SMTP id r11mr972002ugh; Thu, 18 May 2006 16:38:39 -0700 (PDT) Received: from saturn.lan ( [212.143.154.227]) by mx.gmail.com with ESMTP id j1sm1548536ugf.2006.05.18.16.38.36; Thu, 18 May 2006 16:38:38 -0700 (PDT) Date: Fri, 19 May 2006 02:37:32 +0300 From: Rostislav Krasny To: Colin Percival Message-Id: <20060519023732.ea4221dd.rosti.bsd@gmail.com> In-Reply-To: <44554601.5090105@freebsd.org> References: <20060430142408.fcd60069.rosti.bsd@gmail.com> <44554601.5090105@freebsd.org> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.17; i386-portbld-freebsd6.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: is@rambler-co.ru, davidxu@freebsd.org, freebsd-current@freebsd.org Subject: Re: FreeBSD-SA-06:14.fpu X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 May 2006 00:34:43 -0000 On Sun, 30 Apr 2006 16:19:29 -0700 Colin Percival wrote: > Rostislav Krasny wrote: > > Other possible solution is making the fpu_clean_state() optional by > > something like following: > > > > #ifdef BUG_FXSAVE > > #define fpu_clean_state() __fpu_clean_state() > > #else > > #define fpu_clean_state() ; > > #endif > > > > ... and including "options BUG_FXSAVE" to GENERIC. > > Yes, this is probably the right solution. My priority was to fix the > bug; optimizing performance comes second. Ok. Is this solution going to be done some day? I could try to make a patch but I'm not familiar with the build infrastructure internals. P.S. what is a better option name: "options BUG_FXSAVE" or "options AMD_FXSAVE"?