Date: Thu, 14 Feb 2013 18:08:38 +0100 From: Alex Dupre <ale@FreeBSD.org> To: Eitan Adler <eadler@freebsd.org> Cc: svn-doc-head@freebsd.org, svn-doc-all@freebsd.org, doc-committers@freebsd.org, Pietro Cerutti <gahr@freebsd.org> Subject: Re: svn commit: r40970 - head/en_US.ISO8859-1/books/porters-handbook Message-ID: <511D1A16.6040505@FreeBSD.org> In-Reply-To: <CAF6rxg=-8xmtA7vo%2BPRPfkOqYrUPX4ushAmh3ebi6FHs6ooy6Q@mail.gmail.com> References: <201302141435.r1EEZsXu042558@svn.freebsd.org> <511CF790.7040804@FreeBSD.org> <CAF6rxgmY2s79rTi8=2uOif2Oq3r0mN1bAZE2JSgV51tKwmFgjA@mail.gmail.com> <511D0D48.1090000@FreeBSD.org> <CAF6rxg=-8xmtA7vo%2BPRPfkOqYrUPX4ushAmh3ebi6FHs6ooy6Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Eitan Adler ha scritto: > Every time the -pthread vs -lpthread discussion comes up this is brought up. > I have no idea why this is, or who committed it. marcus and kris changed that lines a few times in the past, but PTHREAD_CFLAGS never contained -pthread. The reason is that such variable was intended for FreeBSD and no preprocessor flag is needed since FreeBSD 5. > -pthread also defines certain preproccessor flags and may link in > additional libraries. Yes, it could define other flags and it could link other libraries, but actually it doesn't do it. > Perhaps if one is changing other things it doesn't hurt to also fix > this. It isn't a big priority though. I agree with you that using -pthread on compiling and linking is The Right Thing. My objection is that the porter's handbook says maintainers *must* patch ports to use -pthread. When PTHREAD_CFLAGS/LIBS were added to bsd.port.mk (and such requirements added to porter's handbook) there was a specific actual reason and we should obey. Now there isn't anymore, we can finally live happy and stop patching ports. A more useful addition in the Porter's handbook IMHO would be an entry about 'ltverhack' to avoid useless shared library bumps. Even this is not mandatory, but at least we get a huge gain. -- Alex Dupre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?511D1A16.6040505>