From nobody Mon Nov 10 03:02:21 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d4ZG60w7Rz6GTDD; Mon, 10 Nov 2025 03:02:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d4ZG60841z3b3K; Mon, 10 Nov 2025 03:02:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762743742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Eknf10YwHLh9JFe9poeJOQ0Bc6RZSjfORtEhcWkucYU=; b=xxYjsv4bYdNyBpArU+3IiNuPh/MHCQF9gfL/K/3odNcBqJ2iEfl+xSG99r+oTw8sewb2XA 5uTzBZjDN4VlMmmhIWUGllRjYqJ09bcRYJlrccyUzhMCpb3QdVAdYBkvdpadWSRIETAvIN 9+mABzLPxgXRkgBCG+x9QEk7boQunT2Cs9/akiUDAbsQgQ2kpjWIwk9CLQFZkyRrqqifIL G3jJkUPYVdbJqwoiCg5C+5vf4YpqlIM2r88t4Z4favfcF3JHWIIo7bItB7kbT3O0JDkV40 kFFcX+b9HFzpJBJal4tZJow6+WDHJQhAUeI76N884mqBu2KFTlBAq9jEo5fhMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1762743742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Eknf10YwHLh9JFe9poeJOQ0Bc6RZSjfORtEhcWkucYU=; b=MQJrYZb6KRFojuv0L5T1P5w8JBBzz0NLh0CF/2zLH812ZIqv7plkXuoM0zlLjYn17u8QVh KUKMrErsPI6D9EDKvmFdMnL64w4DIOrd0YS1KVsXOppkbwQH6/mDgVp4LAw4QiHzlm/ysm fypa8eoRwokquvH1QoBd/IK62BaXEEj4MW9ryArMkQ7NUUN5J2QFigpfu+ypWVG67MPU+a og9AW1pPrxFUXVySrSbMbTn9WoFoxSVX7tjcoI9nWXkRHoJ23hhOLWdAHHwAy+aLvO5mgo kQ6l+9enRTuJ2OSEE3AfpWi8BGeRg+3QpwvLgOEDGrFT2KoHc4tQeSJ/bUBYRw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1762743742; a=rsa-sha256; cv=none; b=qNNnqiR7GLrGCSeBcjOY5zV+SWiznTsBphMZdccfnFFcYcYV68I530HhnrW3UVhAAw9AMq 6m+yzdA9lbXB1p1kuhCjf+/oPJUFN2uk0fOvsZBDPzaPyV3HCqAegVBHpft5ekJ+9l7V8U B5FyP6RBny4WIWwkAc5+Qv8Piix7JWBkuHZ7BWnZIX4vR+xQvO/vkNI/tmBDCa/jiSnexA BUhumx7Ui38GqajCAetc2ilv7TjUEGY6bmHBbBJYP94Ou0ZCqRmrdj4WhoQBTWAPoEdnho M7pjIRN+q7Gw1yR9Z6NlZHvE73iw++Kuu7SQ9sL85l7P3gHiTGWLN7cxcHV1Qw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4d4ZG56nb3z10rl; Mon, 10 Nov 2025 03:02:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5AA32LEf008360; Mon, 10 Nov 2025 03:02:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5AA32LVa008357; Mon, 10 Nov 2025 03:02:21 GMT (envelope-from git) Date: Mon, 10 Nov 2025 03:02:21 GMT Message-Id: <202511100302.5AA32LVa008357@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: dbb34d496708 - main - newfs_msdos: Improve error messages List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: dbb34d496708a37763d3d8bf6782991dee10d17e Auto-Submitted: auto-generated The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=dbb34d496708a37763d3d8bf6782991dee10d17e commit dbb34d496708a37763d3d8bf6782991dee10d17e Author: Ed Maste AuthorDate: 2025-11-09 19:43:50 +0000 Commit: Ed Maste CommitDate: 2025-11-10 03:02:09 +0000 newfs_msdos: Improve error messages - Report overly long OEM string as too long, not just "bad". - Use warn instead of warnx for open or ftruncate failure to report the error string. Reviewed by: se Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D53649 --- sbin/newfs_msdos/mkfs_msdos.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sbin/newfs_msdos/mkfs_msdos.c b/sbin/newfs_msdos/mkfs_msdos.c index dcc2bb982efc..a570d92cd17b 100644 --- a/sbin/newfs_msdos/mkfs_msdos.c +++ b/sbin/newfs_msdos/mkfs_msdos.c @@ -264,7 +264,7 @@ mkfs_msdos(const char *fname, const char *dtype, const struct msdos_options *op) goto done; } if (o.OEM_string && strlen(o.OEM_string) > 8) { - warnx("%s: bad OEM string", o.OEM_string); + warnx("%s: OEM string too long", o.OEM_string); goto done; } if (o.create_size) { @@ -274,11 +274,11 @@ mkfs_msdos(const char *fname, const char *dtype, const struct msdos_options *op) } fd = open(fname, O_RDWR | O_CREAT | O_TRUNC, 0644); if (fd == -1) { - warnx("failed to create %s", fname); + warn("failed to create %s", fname); goto done; } if (ftruncate(fd, o.create_size)) { - warnx("failed to initialize %jd bytes", (intmax_t)o.create_size); + warn("failed to initialize %jd bytes", (intmax_t)o.create_size); goto done; } } else if ((fd = open(fname, o.no_create ? O_RDONLY : O_RDWR)) == -1) {