From owner-freebsd-hackers@FreeBSD.ORG  Sun Jul 10 05:19:41 2011
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7550C1065670;
	Sun, 10 Jul 2011 05:19:41 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 3248B8FC13;
	Sun, 10 Jul 2011 05:19:41 +0000 (UTC)
Received: from 63.imp.bsdimp.com (63.imp.bsdimp.com [10.0.0.63])
	(authenticated bits=0)
	by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id p6A5HNgs012206
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO);
	Sat, 9 Jul 2011 23:17:23 -0600 (MDT) (envelope-from imp@bsdimp.com)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <CAOfDtXMGdyD5LPvjdd9rS4v-rtkeJ7M=v4vyUtF-Wg23bjvtGw@mail.gmail.com>
Date: Sat, 9 Jul 2011 23:17:22 -0600
Content-Transfer-Encoding: quoted-printable
Message-Id: <EEF7E857-0693-4871-9F29-02A1AC146795@bsdimp.com>
References: <CAOfDtXMHdVm+7DFr=ZV4x_5uQ=q+2A0cFxvZsUgGzqWEwURhYg@mail.gmail.com>
	<4E12E358.80002@FreeBSD.org>
	<CAOfDtXMGdyD5LPvjdd9rS4v-rtkeJ7M=v4vyUtF-Wg23bjvtGw@mail.gmail.com>
To: Robert Millan <rmh@debian.org>
X-Mailer: Apple Mail (2.1084)
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(harmony.bsdimp.com [10.0.0.6]);
	Sat, 09 Jul 2011 23:17:23 -0600 (MDT)
Cc: freebsd-hackers@FreeBSD.org, Dimitry Andric <dim@FreeBSD.org>,
	Ed Maste <emaste@FreeBSD.org>
Subject: Re: [PATCH] __FreeBSD_cc_version in <sys/cdefs.h>
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jul 2011 05:19:41 -0000


On Jul 5, 2011, at 7:36 AM, Robert Millan wrote:

> 2011/7/5 Dimitry Andric <dim@freebsd.org>:
>> As far as I can see, this code only gives warnings when compiled with
>> gcc 4.5 or higher, and when using the -Wundef flag.  Isn't it easier =
to
>> just remove the -Wundef flag here?
>=20
> Here's a patch to remove -Wundef.  I think it's a bad idea however,
> IMHO it's better to fix the cause of the warning instead.

I think it is a better idea to fix the warning too.  I liked your first =
patch better.

Warner