Date: Sat, 9 Jul 2011 23:17:22 -0600 From: Warner Losh <imp@bsdimp.com> To: Robert Millan <rmh@debian.org> Cc: freebsd-hackers@FreeBSD.org, Dimitry Andric <dim@FreeBSD.org>, Ed Maste <emaste@FreeBSD.org> Subject: Re: [PATCH] __FreeBSD_cc_version in <sys/cdefs.h> Message-ID: <EEF7E857-0693-4871-9F29-02A1AC146795@bsdimp.com> In-Reply-To: <CAOfDtXMGdyD5LPvjdd9rS4v-rtkeJ7M=v4vyUtF-Wg23bjvtGw@mail.gmail.com> References: <CAOfDtXMHdVm%2B7DFr=ZV4x_5uQ=q%2B2A0cFxvZsUgGzqWEwURhYg@mail.gmail.com> <4E12E358.80002@FreeBSD.org> <CAOfDtXMGdyD5LPvjdd9rS4v-rtkeJ7M=v4vyUtF-Wg23bjvtGw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 5, 2011, at 7:36 AM, Robert Millan wrote: > 2011/7/5 Dimitry Andric <dim@freebsd.org>: >> As far as I can see, this code only gives warnings when compiled with >> gcc 4.5 or higher, and when using the -Wundef flag. Isn't it easier = to >> just remove the -Wundef flag here? >=20 > Here's a patch to remove -Wundef. I think it's a bad idea however, > IMHO it's better to fix the cause of the warning instead. I think it is a better idea to fix the warning too. I liked your first = patch better. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EEF7E857-0693-4871-9F29-02A1AC146795>