From owner-freebsd-net@FreeBSD.ORG Wed Apr 15 17:45:04 2015 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E63FC6D3; Wed, 15 Apr 2015 17:45:04 +0000 (UTC) Received: from mail-oi0-x232.google.com (mail-oi0-x232.google.com [IPv6:2607:f8b0:4003:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9BF45387; Wed, 15 Apr 2015 17:45:04 +0000 (UTC) Received: by oign205 with SMTP id n205so32849887oig.2; Wed, 15 Apr 2015 10:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=hphEI9O5LcSfpC5zE1nQJWTcA6jCeu5tsR2/Zx//ICE=; b=VswTcbrgEfGeD5UcZEmZq2XI+ptLRYRxNcOeIx63PG49ACbdUmmtueV6/6OTDFnvlF RmsbLjy6HsNy/I1m46sh/A/BcaMqIX0ob2tzqPr3dJLe7AqkRz7fbywi5wI81KCzps8Z UCF2IUB1o0H6B4sABvBqT6NUBzGfu8XP/Lnh+RiFo6uYiIfqPnCyW7mo9M9cUsOr6/Uh op73JPTuQNn5p91Nc125SyqEj+ESLHs0du5WcEHi+aUM4Y+n77qmmffgCfXE9qDzZdCk aPz3n7/55h3T+Y5FRRjClwRg08IM8jUGS3gu/rpiNuqEgKfgkf6KXW0kCmkh02nq75q8 gPLA== MIME-Version: 1.0 X-Received: by 10.182.29.136 with SMTP id k8mr22254357obh.60.1429119898876; Wed, 15 Apr 2015 10:44:58 -0700 (PDT) Received: by 10.202.44.196 with HTTP; Wed, 15 Apr 2015 10:44:58 -0700 (PDT) In-Reply-To: <20150415122627.GZ883@glebius.int.ru> References: <20150414135346.GU883@FreeBSD.org> <20150415073823.GA94402@onelab2.iet.unipi.it> <20150415122627.GZ883@glebius.int.ru> Date: Wed, 15 Apr 2015 10:44:58 -0700 Message-ID: Subject: Re: moving ALTQ out of contrib From: Nick Rogers To: Gleb Smirnoff Cc: Luigi Rizzo , "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2015 17:45:05 -0000 On Wed, Apr 15, 2015 at 5:26 AM, Gleb Smirnoff wrote: > On Wed, Apr 15, 2015 at 09:38:23AM +0200, Luigi Rizzo wrote: > L> > With the new ifnet KPI, that is now being developed in > projects/ifnet, > L> > the ALTQ will need some tweaking. It is discontinued by initial author > L> > for a decade now, and it has already experienced direct commits in > L> > our tree. Thus, I see no good reasons to continue keeping it in > contrib. > L> > In NetBSD they have it in sys/altq. > L> > > L> > I'd prefer to move it to sys/net/altq. > L> > > L> > Any objections or better ideas? > L> > L> my first question is what is the expected residual lifetime of altq ? > > If I get it working properly in projects/ifnet, I see no reasons to > remove it. It is going to be a plugin into network stack and will no > longer require editing drivers. It will run on drivers that aren't > supported by ALTQ now. However in the latter case the ALTQ will sit > on top of interface own queue, and will start to work only when > interface's own queue overflows. But if we later add a new interface > method to modify length of own queue at runtime, this issue will > go away. > For what its worth, I maintain 300+ systems acting as PF+ALTQ routers, among other things. I've been doing this for the last 8 years or so (since 7.2 and now running 10.1), and have dealt with all the issues and workarounds surrounding lack of multiqueue support and driver compatibility, but at the end of the day ALTQ still does the job despite its performance issues. I would be in bad shape if it were simply removed at some point in the future. The changes you propose to not only keep it around officially, but make it more driver-agnostic and possibly behave better with multiqueue, sound absolutely fantastic. Thank you. > L> If it is destined to be removed soon (and probably that is not > L> unlikely given its unmaintained state, the absence of multiqueue > L> support etc.) maybe we could live for the next > L> couple of years just leaving it where it is now and avoid the > L> repo churn. > L> > L> If we really plan to relocate the code, I guess the options are > L> > L> sys/altq as in netbsd > L> > L> sys/netaltq this would be an alternative location to > L> the above one, justified by the fact that > L> we have already a bunch of net* subdirs > L> > L> sys/net/altq as you propose, i guess to stay close to > L> the rest of the ifnet code (and perhaps > L> as a first step in cleaning up sys/net > L> by putting stuff in various subdirs) > L> > L> In any case my preference would really be to leave it where it is. > > I don't like to keep in contrib a code maintained and edited by the > project. Especially I don't like tautological path of contrib/altq/altq. > I don't like extra glue in Makefiles, especially modyfing CFLAGS for the > whole kernel build. > I'm not a major committer other than the occasional patch submission for various things, but the contrib/altq location has always perplexed me. I don't see it as a contribution. > If it is a regular piece of kernel code, let it be like the rest of > kernel code. > > -- > Totus tuus, Glebius. > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >