Date: Thu, 22 Mar 2012 18:20:57 +0000 From: Chris Rees <crees@freebsd.org> To: Michael Scheidell <scheidell@freebsd.org> Cc: cvs-ports@freebsd.org, Wesley Shields <wxs@freebsd.org>, Doug Barton <dougb@freebsd.org>, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/graphics/opennurbs Makefile pkg-plist Message-ID: <CADLo838ryiKRrtAvJC7cme%2B-=q=WZ%2BZiez0xWGu3daLCGgzQHg@mail.gmail.com> In-Reply-To: <4F6B660E.5080205@freebsd.org> References: <201203191403.q2JE3sM8051201@repoman.freebsd.org> <20120319143041.GB27552@atarininja.org> <4F67438C.605@freebsd.org> <20120320022942.GC27552@atarininja.org> <4F67FCF1.807@FreeBSD.org> <4F6B660E.5080205@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22 March 2012 17:49, Michael Scheidell <scheidell@freebsd.org> wrote:
> On 3/19/12 11:43 PM, Doug Barton wrote:
>>
>> On 3/19/2012 7:29 PM, Wesley Shields wrote:
>>>
>>> On Mon, Mar 19, 2012 at 10:32:44AM -0400, Michael Scheidell wrote:
>>>>>
>>>>>
>>>>> On 3/19/12 10:30 AM, Wesley Shields wrote:
>>>>>>>
>>>>>>> Isn't it better to use ${INSTALL_DATA} here?
>>>>>>>
>>>>>>> -- WXS
>>>>>
>>>>> open a pr, let maintainer approve it.
>>>
>>> As the person who committed this it is your responsibility to see that
>>> issues raised are properly fixed. If you feel like the maintainer shoul=
d
>>> be brought in for such a simple change that is your decision to make,
>>> but I shouldn't have to open a PR to address this.
>>
>> +1
>>
>>
> yeh doug, like this one?
>
> which I sent to you privately, after you editied makefile and redid how
> PORTDOCS worked by changing it to the macro? weren't you the last committ=
er?
> <http://www.freebsd.org/cgi/query-pr.cgi?pr=3D165167>; =A0oh, and not only=
the
> last committer, but you wrote the actual patch!
>
> Look what you left on the filesystem after pkg deleted because you didn't
> look at the Makefile and see the obvious mistake:
>
> <http://people.freebsd.org/~scheidell/smartmontools-5.42_3.log>;
>
> Don't you ever test your patches first?
>
> Have some common courtesy, all of you. =A0I will continue to privately se=
nd a
> patch to a member of our team, and, offer to open a PR if they insist.
> (i opened a pr <http://www.freebsd.org/cgi/query-pr.cgi?pr=3D165670>; =A0M=
arch
> 3rd, after sending Doug a private email on Feb 27th. =A0He finally got ba=
ck to
> me and told me to open a pr.. I didn't send a public flogging email
> demanding that at the last committer he fix it, and, I would not have,
> hoping that by example, he would maybe learn that a quick, private email,
> with a patch, or suggestion, or real explanation of the problem was bette=
r
> than public flogging.
>
> =A0Even if I get cryptic emails demanding I fix something and am never to=
ld
> what it broke. =A0When it actually does break something, I make it a prio=
rity
> to fix it, and if you have seen my lead time on real emergencies, its, li=
ke,
> what, 5 mins after the tinderbox got finished with it?
>
> I am sorry that the mv inserted by the maintainer caused such an
> international incident, maybe someone should edit portlint and look for
> ${MV} or \bmv\b ?
>
> No, stop wasting time, and start back to making FreeBSD the best choice,
> best operating system for discriminating system admins.
Hi Michael,
I recognise your concerns here, I really do.
However, portlint isn't designed to tell you if your code is broken or
not-- it's something you have to learn, and if necessary review with
others (I know you have a good record of asking for review). Use of
${MV} isn't inherently wrong, it is just wrong here.
In this case, although it's not a international incident, it's still
incorrect code that needs fixing. Please don't point to others as
precedent to ignore common practices-- if they have caused an issue,
take it up with them; don't follow their lead!
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo838ryiKRrtAvJC7cme%2B-=q=WZ%2BZiez0xWGu3daLCGgzQHg>