From owner-cvs-src@FreeBSD.ORG Fri Jun 30 06:26:42 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6C16716A4D2; Fri, 30 Jun 2006 06:26:41 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id D588444336; Fri, 30 Jun 2006 05:59:41 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [IPv6:::1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k5U5wvXF085189; Thu, 29 Jun 2006 23:58:57 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 29 Jun 2006 23:58:56 -0600 (MDT) Message-Id: <20060629.235856.74667657.imp@bsdimp.com> To: jhb@freebsd.org From: Warner Losh In-Reply-To: <200606270848.29250.jhb@freebsd.org> References: <200606261834.k5QIYkEF005337@repoman.freebsd.org> <44A0708C.4090703@errno.com> <200606270848.29250.jhb@freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: sam@errno.com, src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_module.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2006 06:26:42 -0000 From: John Baldwin Subject: Re: cvs commit: src/sys/kern kern_module.c Date: Tue, 27 Jun 2006 08:48:28 -0400 > On Monday 26 June 2006 19:41, Sam Leffler wrote: > > John Baldwin wrote: > > > jhb 2006-06-26 18:34:45 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/kern kern_module.c > > > Log: > > > Address a problem I missed in removing Giant from the kernel linker. Not > > > all of the module event handlers are MP safe yet, so always acquire Giant > > > for now when invoking module event handlers. Eventually we can add an > > > MPSAFE flag or some such and add appropriate locking to all module event > > > handlers. > > > > I suggest we should be marking things !MPSAFE rather than MPSAFE. > > > > Sam > > I would prefer that as well but that would require an exhaustive search of > all existing module event handlers to determine MPSAFE-ness up front. With > the mark as MPSAFE method (such as we've used for syscalls) we can mark things > MPSAFE (and/or add locking to make them MPSAFE) while doing the exhaustive > search and eventually when all are MPSAFE we can remove the flag (which I'm > in the process of doing now with the syscall flag) all the while having a > functioning system. We have three cases right now: (1) Unknown (2) MPSAFE (3) NEEDS GIANT All the unknown ones need giant right now, or at least that's a reasonable guess. Certainly all the device driver ones do since you need giant to do certain device tree activities. Short of introducing a new API, I'm unsure how we'd be able to effectively and safely do NEEDS_GIANT marking in the interrum. Warner