From owner-freebsd-current Sat Nov 6 10:26:37 1999 Delivered-To: freebsd-current@freebsd.org Received: from mail.HiWAAY.net (fly.HiWAAY.net [208.147.154.56]) by hub.freebsd.org (Postfix) with ESMTP id 0630414E46 for ; Sat, 6 Nov 1999 10:26:35 -0800 (PST) (envelope-from sprice@hiwaay.net) Received: from localhost (sprice@localhost) by mail.HiWAAY.net (8.9.1a/8.9.0) with ESMTP id MAA24279; Sat, 6 Nov 1999 12:26:33 -0600 (CST) Date: Sat, 6 Nov 1999 12:26:33 -0600 (CST) From: Steve Price To: Nate Williams Cc: freebsd-current@FreeBSD.ORG Subject: Re: gzip(1) hanging In-Reply-To: <199911061800.LAA24683@mt.sri.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 6 Nov 1999, Nate Williams wrote: # > I've got a -current box freshly CVSup'd and built from last # > night that is exhibiting some rather bizarre behavior. I # > actually noticed the problem on my Alpha package building # > machine, but the same behavior exists on my i386 box. # > # > To see what I'm seeing (or maybe not :) all you have to do # > is this: # > # > cd /usr/ports/graphics/jpeg # > make extract # # Martin C. made a change to 'sh' yesterday with regards to # file-descriptors that might have something to do with this... Great catch Nate! The following patch fixes the problem that I'm seeing and still addresses the problem Martin was trying to fix as part of bin/14527. Index: eval.c =================================================================== RCS file: /home/ncvs/src/bin/sh/eval.c,v retrieving revision 1.23 diff -u -r1.23 eval.c --- eval.c 1999/11/05 12:06:30 1.23 +++ eval.c 1999/11/06 18:18:23 @@ -499,7 +499,7 @@ close(prevfd); } if (pip[1] >= 0) { - if (!prevfd > 0) + if (prevfd < 0) close(pip[0]); if (pip[1] != 1) { close(1); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message