Date: Sat, 18 Feb 2023 23:11:59 +0100 From: Moin Rahman <bofh@freebsd.org> To: Antoine Brodin <antoine@freebsd.org> Cc: "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "dev-commits-ports-all@freebsd.org" <dev-commits-ports-all@freebsd.org>, "dev-commits-ports-main@freebsd.org" <dev-commits-ports-main@freebsd.org> Subject: Re: git: 1c1e0975ade6 - main - databases/mysql-connector-odbc: remove expired port Message-ID: <95E651CF-5C8F-4D17-8AC5-44E9C35E4963@freebsd.org> In-Reply-To: <CAALwa8nWS8=P6G%2B0u0wz8gGrqvTzj9e1UeEFQK1XkwW04iqp0w@mail.gmail.com> References: <202302182007.31IK7JWK071189@gitrepo.freebsd.org> <B314D9F6-D986-455B-8FFC-8ECCBF8A262B@freebsd.org> <CAALwa8kEgi353Wg6Q2r22roCVeOZwOwDZMYNUKbZuCzfJj%2B8TA@mail.gmail.com> <F8E09111-EEF6-402C-8D22-DC1A6AE9D78F@freebsd.org> <CAALwa8nWS8=P6G%2B0u0wz8gGrqvTzj9e1UeEFQK1XkwW04iqp0w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_ACCE3B31-1230-4660-9CB6-8A2AA3B255BB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Feb 18, 2023, at 11:03 PM, Antoine Brodin <antoine@freebsd.org> = wrote: >=20 > On Sat, Feb 18, 2023 at 10:01 PM Moin Rahman <bofh@freebsd.org> wrote: >>=20 >> Unless you are confused or watching the logs of mysql exp-run for = changing the default version this is not correct. >>=20 >> Just for the sake of the conversation I have rebuilt the ports with = now mysql 5.7 as default and here are the results: >> = https://pdr.bofh.network/data/latest-per-pkg/mysql-connector-odbc-unixodbc= -mysql57/5.3.14/123-default.log >> = https://pdr.bofh.network/data/latest-per-pkg/mysql-connector-odbc-unixodbc= -mysql57/5.3.14/123i386-default.log >> = https://pdr.bofh.network/data/latest-per-pkg/mysql-connector-odbc-unixodbc= -mysql57/5.3.14/131-default.log >>=20 >> And neither do I see any PKGBASE conflicts: >> cd databases/mysql-connector-odbc && make -v PKGBASE >> cd databases/mysql-connector-odbc-80 && = mysql-connector-odbc-unixodbc-mysql57 >> make -v PKGBASE >> mysql-connector-odbc-unixodbc-mysql80 >>=20 >> Please revert. >=20 > The default version of mysql switched to mysql 8.0 so there is a > PKGBASE conflict. > I think mysql-connector-odbc should have used USES=3Dmysql:somever That does not imply that you have to remove this. > Antoine >=20 >>> On Feb 18, 2023, at 9:40 PM, Antoine Brodin <antoine@FreeBSD.org> = wrote: >>>=20 >>> On Sat, Feb 18, 2023 at 8:16 PM Moin Rahman <bofh@freebsd.org> = wrote: >>>>=20 >>>> Why did you expire this port? This is marked to expire on = 2012-12-31. >>>=20 >>> It has not been built for months (ignored) and its PKGBASE now >>> collides with mysql-connector-odbc-80. >>>=20 >>> Antoine >>>=20 >>>> On Feb 18, 2023, at 9:07 PM, Antoine Brodin <antoine@FreeBSD.org> = wrote: >>>>=20 >>>> The branch main has been updated by antoine: >>>>=20 >>>> URL: = https://cgit.FreeBSD.org/ports/commit/?id=3D1c1e0975ade679a1f13c10709cf443= bc82dde3b9 >>>>=20 >>>> commit 1c1e0975ade679a1f13c10709cf443bc82dde3b9 >>>> Author: Antoine Brodin <antoine@FreeBSD.org> >>>> AuthorDate: 2023-02-18 20:06:29 +0000 >>>> Commit: Antoine Brodin <antoine@FreeBSD.org> >>>> CommitDate: 2023-02-18 20:06:29 +0000 >>>>=20 >>>> databases/mysql-connector-odbc: remove expired port >>>> --- >>>> MOVED | 1 + >>>> databases/Makefile | 1 - >>>> databases/mysql-connector-odbc/Makefile | 38 = ---------------------- >>>> databases/mysql-connector-odbc/distinfo | 3 -- >>>> .../files/patch-CMakeLists.txt | 30 = ----------------- >>>> .../mysql-connector-odbc/files/patch-driver_dll.cc | 11 ------- >>>> .../files/patch-driver_handle.cc | 11 ------- >>>> databases/mysql-connector-odbc/pkg-descr | 1 - >>>> 8 files changed, 1 insertion(+), 95 deletions(-) >>>>=20 >>>> diff --git a/MOVED b/MOVED >>>> index bfe2d1dcb026..6823b3c2e314 100644 >>>> --- a/MOVED >>>> +++ b/MOVED >>>> @@ -17765,3 +17765,4 @@ = x11/plasma5-kwayland-server|x11-wm/plasma5-kwin|2023-02-07|Reintegrated = into x11 >>>> finance/py-TA-Lib|finance/py-ta-lib|2023-02-12|Remove duplicate = port >>>> x11-toolkits/gnocl||2023-02-13|Fails to build, newer snapshot = depends on a removed port >>>> games/opendungeons||2023-02-14|Has expired: Broken for more than 6 = months >>>> = +databases/mysql-connector-odbc|databases/mysql-connector-odbc-80|2023-02-= 18|Has expired: Requires EOLd mysql version >>>> diff --git a/databases/Makefile b/databases/Makefile >>>> index 3a6cbb867cc9..598e34d376ae 100644 >>>> --- a/databases/Makefile >>>> +++ b/databases/Makefile >>>> @@ -204,7 +204,6 @@ >>>> SUBDIR +=3D mysql-connector-c++ >>>> SUBDIR +=3D mysql-connector-java >>>> SUBDIR +=3D mysql-connector-java51 >>>> - SUBDIR +=3D mysql-connector-odbc >>>> SUBDIR +=3D mysql-connector-odbc-80 >>>> SUBDIR +=3D mysql-q4m >>>> SUBDIR +=3D mysql-udf >>>> diff --git a/databases/mysql-connector-odbc/Makefile = b/databases/mysql-connector-odbc/Makefile >>>> deleted file mode 100644 >>>> index b61392aee08b..000000000000 >>>> --- a/databases/mysql-connector-odbc/Makefile >>>> +++ /dev/null >>>> @@ -1,38 +0,0 @@ >>>> -PORTNAME=3D mysql-connector-odbc >>>> -PORTVERSION=3D 5.3.14 >>>> -CATEGORIES=3D databases >>>> -MASTER_SITES=3D MYSQL/Connector-ODBC/5.3 >>>> -PKGNAMESUFFIX=3D -${DRIVER_MANAGER}-mysql${MYSQL_VER} >>>> -DISTNAME=3D ${PORTNAME}-${PORTVERSION}-src >>>> - >>>> -MAINTAINER=3D bofh@FreeBSD.org >>>> -COMMENT=3D ODBC driver for MySQL${MYSQL_VER} / ${DRIVER_MANAGER} >>>> -WWW=3D https://www.mysql.com/ >>>> - >>>> -LICENSE=3D GPLv2 >>>> -LICENSE_FILE=3D ${WRKSRC}/LICENSE.txt >>>> - >>>> -DEPRECATED=3D Requires EOLd mysql version >>>> -EXPIRATION_DATE=3D 2023-12-31 >>>> - >>>> -LIB_DEPENDS=3D libodbc.so:databases/unixODBC >>>> - >>>> -USES=3D cmake compiler:c++11-lang localbase:ldflags mysql ssl >>>> -IGNORE_WITH_MYSQL=3D 101m 102m 103m 57p 57w 80 >>>> -USE_LDCONFIG=3D yes >>>> - >>>> -CMAKE_ARGS=3D -DDISABLE_GUI=3D1 \ >>>> - -DWITH_UNIXODBC=3D1 >>>> - >>>> -MAKE_JOBS_UNSAFE=3D yes >>>> - >>>> -DRIVER_MANAGER=3D unixodbc >>>> - >>>> -PLIST_FILES=3D bin/myodbc-installer \ >>>> - lib/libmyodbc5a.so \ >>>> - lib/libmyodbc5w.so >>>> -PORTDOCS=3D * >>>> - >>>> -OPTIONS_DEFINE=3D DOCS >>>> - >>>> -.include <bsd.port.mk> >>>> diff --git a/databases/mysql-connector-odbc/distinfo = b/databases/mysql-connector-odbc/distinfo >>>> deleted file mode 100644 >>>> index 702e816bc4ff..000000000000 >>>> --- a/databases/mysql-connector-odbc/distinfo >>>> +++ /dev/null >>>> @@ -1,3 +0,0 @@ >>>> -TIMESTAMP =3D 1675364196 >>>> -SHA256 (mysql-connector-odbc-5.3.14-src.tar.gz) =3D = 302d068ef0d8e1e9ada6e42e48c149151d4b722f9317efb106f801e483e74a7f >>>> -SIZE (mysql-connector-odbc-5.3.14-src.tar.gz) =3D 3010166 >>>> diff --git = a/databases/mysql-connector-odbc/files/patch-CMakeLists.txt = b/databases/mysql-connector-odbc/files/patch-CMakeLists.txt >>>> deleted file mode 100644 >>>> index f184b2a0e6f4..000000000000 >>>> --- a/databases/mysql-connector-odbc/files/patch-CMakeLists.txt >>>> +++ /dev/null >>>> @@ -1,30 +0,0 @@ >>>> ---- CMakeLists.txt.orig 2019-04-15 16:56:34 UTC >>>> -+++ CMakeLists.txt >>>> -@@ -431,7 +431,6 @@ ENDIF(NOT DISABLE_GUI) >>>> - >>>> - ADD_SUBDIRECTORY(dltest) >>>> - ADD_SUBDIRECTORY(installer) >>>> --ADD_SUBDIRECTORY(test) >>>> - >>>> - # For dynamic linking use the built-in sys and strings >>>> - IF(NOT MYSQLCLIENT_STATIC_LINKING) >>>> -@@ -501,8 +500,8 @@ cmake/sql.*\\\\.c$ >>>> - #------------ Installation --------------------------- >>>> - >>>> - >>>> --INSTALL(FILES LICENSE.txt DESTINATION .) >>>> --INSTALL(FILES README.txt DESTINATION .) >>>> -+INSTALL(FILES LICENSE.txt DESTINATION = ./share/doc/mysql-connector-odbc/) >>>> -+INSTALL(FILES README.txt DESTINATION = ./share/doc/mysql-connector-odbc/) >>>> - >>>> - IF(WIN32) >>>> - >>>> -@@ -542,7 +541,7 @@ IF(WIN32) >>>> - >>>> - ELSE(WIN32) >>>> - >>>> -- INSTALL(FILES ChangeLog DESTINATION .) >>>> -+ INSTALL(FILES ChangeLog DESTINATION = ./share/doc/mysql-connector-odbc/) >>>> - >>>> - ENDIF(WIN32) >>>> - >>>> diff --git = a/databases/mysql-connector-odbc/files/patch-driver_dll.cc = b/databases/mysql-connector-odbc/files/patch-driver_dll.cc >>>> deleted file mode 100644 >>>> index b69ce6b9e812..000000000000 >>>> --- a/databases/mysql-connector-odbc/files/patch-driver_dll.cc >>>> +++ /dev/null >>>> @@ -1,11 +0,0 @@ >>>> ---- driver/dll.cc.orig 2019-04-15 16:56:34 UTC >>>> -+++ driver/dll.cc >>>> -@@ -125,7 +125,7 @@ void myodbc_end() >>>> - This eliminates the delay when mysys_end() is called and = other threads >>>> - have been initialized but not ended. >>>> - */ >>>> -- my_thread_end_wait_time=3D 0; >>>> -+ static uint my_thread_end_wait_time=3D 0; >>>> - #endif >>>> - >>>> - /* >>>> diff --git = a/databases/mysql-connector-odbc/files/patch-driver_handle.cc = b/databases/mysql-connector-odbc/files/patch-driver_handle.cc >>>> deleted file mode 100644 >>>> index 3a12e522fa4e..000000000000 >>>> --- a/databases/mysql-connector-odbc/files/patch-driver_handle.cc >>>> +++ /dev/null >>>> @@ -1,11 +0,0 @@ >>>> ---- driver/handle.cc.orig 2019-04-15 16:56:34 UTC >>>> -+++ driver/handle.cc >>>> -@@ -646,7 +646,7 @@ SQLRETURN SQL_API = my_SQLFreeStmtExtended(SQLHSTMT hstm >>>> - #if MYSQL_VERSION_ID >=3D 50722 && MYSQL_VERSION_ID < 80000 >>>> - if (stmt->result !=3D NULL >>>> - #else >>>> -- if((stmt->result !=3D NULL) && (stmt->result->field_alloc = !=3D NULL) >>>> -+ if((stmt->result !=3D NULL) && (&stmt->result->field_alloc = !=3D NULL) >>>> - #if (!MYSQLCLIENT_STATIC_LINKING || !MYSQL8) >>>> - && (stmt->result->field_alloc.pre_alloc !=3D NULL ) >>>> - #endif >>>> diff --git a/databases/mysql-connector-odbc/pkg-descr = b/databases/mysql-connector-odbc/pkg-descr >>>> deleted file mode 100644 >>>> index 0441dd6a5d7f..000000000000 >>>> --- a/databases/mysql-connector-odbc/pkg-descr >>>> +++ /dev/null >>>> @@ -1 +0,0 @@ >>>> -MySQL Connector ODBC is an ODBC driver for interfacing to MySQL = databases. --Apple-Mail=_ACCE3B31-1230-4660-9CB6-8A2AA3B255BB Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEETfdREoUGjQZKBS+fvbm1phfAvJEFAmPxTS9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDRE Rjc1MTEyODUwNjhEMDY0QTA1MkY5RkJEQjlCNUE2MTdDMEJDOTEACgkQvbm1phfA vJFeGw//drhunwpeF+gOfYGLbmrBuAjNcICrSSGgCyL1e2UzG4Q8Hr03biPW1jkm RfDEhbIpCVlYp2D0/X2Qy8WOYq8Q67tgNH4XgPnPi+sFRS4HvwzzRYMUphUG9QQF wqMhnU5gSawgG9Q09MpT56LP/kfTVx6mujBvWPCy9RiQU7qbA9FhOwNrpq5jgxOP I0nkpijVpuGNdaJ/axugeSL+RaKfIE1fPXLVDGDnWwYYzChadyIEqCam2104sR1i U1eDh8QzxgvzHz7a5s5T++D3OFp82dO84iy1br7nFU9MH3potO0SGv+4PRs7znry VpNwiqNEvpvDDCJfvcFGvB+ParbG3idf3fGQyvInoHiv5Au3sqbiMY6w+OS9DHSA m2oTw0D54YVuzjZ6By9RUmlKKesgJWbqPTcNeEjFdm19AQrFsFLhJhy8nhkHVV3D NEHOrblEn+DXmoQlx+nNLATC6tSWiv3HPKV4TtfWP0IxD2N4jMRdB/ZtkgBmvOX7 EbP5/8uhHch7gFxphl7RslYq3vujHTVvvrpMtbw1vEKRqLHMHb+sBLtShv1BOfOo pIg6mtVHlw0AeZW6FEG4PtHaJvZg/4UXWiBxy8mv3sOeBU0WcGjLNfdPD2v3fUXn LY+Fx5QorWEDgQfi7Zb/ywVgP2pF5/d0DIRNp+9ef2NDOXBBZOw= =GMw0 -----END PGP SIGNATURE----- --Apple-Mail=_ACCE3B31-1230-4660-9CB6-8A2AA3B255BB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?95E651CF-5C8F-4D17-8AC5-44E9C35E4963>