From owner-svn-src-all@FreeBSD.ORG Sun Nov 6 19:01:55 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 34BDD10657AE; Sun, 6 Nov 2011 19:01:55 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 24DEC8FC20; Sun, 6 Nov 2011 19:01:55 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id pA6J1svU036935; Sun, 6 Nov 2011 19:01:54 GMT (envelope-from ed@svn.freebsd.org) Received: (from ed@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id pA6J1sM6036933; Sun, 6 Nov 2011 19:01:54 GMT (envelope-from ed@svn.freebsd.org) Message-Id: <201111061901.pA6J1sM6036933@svn.freebsd.org> From: Ed Schouten Date: Sun, 6 Nov 2011 19:01:54 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r227253 - head/usr.sbin/fdread X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Nov 2011 19:01:55 -0000 Author: ed Date: Sun Nov 6 19:01:54 2011 New Revision: 227253 URL: http://svn.freebsd.org/changeset/base/227253 Log: Mark global functions and/or variables in fdread(8) static where possible. This allows compilers and static analyzers to do more thorough analysis. Modified: head/usr.sbin/fdread/fdread.c Modified: head/usr.sbin/fdread/fdread.c ============================================================================== --- head/usr.sbin/fdread/fdread.c Sun Nov 6 19:01:48 2011 (r227252) +++ head/usr.sbin/fdread/fdread.c Sun Nov 6 19:01:54 2011 (r227253) @@ -44,14 +44,14 @@ #include "fdutil.h" -int quiet, recover; -unsigned char fillbyte = 0xf0; /* "foo" */ +static int quiet, recover; +static unsigned char fillbyte = 0xf0; /* "foo" */ -int doread(int fd, FILE *of, const char *_devname); -int doreadid(int fd, unsigned int numids, unsigned int trackno); -void usage(void); +static int doread(int fd, FILE *of, const char *_devname); +static int doreadid(int fd, unsigned int numids, unsigned int trackno); +static void usage(void); -void +static void usage(void) { @@ -155,7 +155,7 @@ main(int argc, char **argv) return (numids? doreadid(fd, numids, trackno): doread(fd, of, _devname)); } -int +static int doread(int fd, FILE *of, const char *_devname) { char *trackbuf; @@ -294,7 +294,7 @@ doread(int fd, FILE *of, const char *_de return (nerrs? EX_IOERR: EX_OK); } -int +static int doreadid(int fd, unsigned int numids, unsigned int trackno) { int rv = 0;