From owner-cvs-src@FreeBSD.ORG  Thu Sep  4 01:35:30 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A3A1816A4BF; Thu,  4 Sep 2003 01:35:30 -0700 (PDT)
Received: from exc-1.cc.CyberCity.dk (esplanaden.cybercity.dk
	[212.242.40.114])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E761543FE0; Thu,  4 Sep 2003 01:35:27 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk ([172.16.7.254]) by exc-1.cc.CyberCity.dk
	over TLS secured channel with Microsoft SMTPSVC(5.0.2195.6713);
	Thu, 4 Sep 2003 10:35:26 +0200
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h848ZFJE001200;
	Thu, 4 Sep 2003 10:35:20 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: Doug Rabson <dfr@nlsystems.com>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "04 Sep 2003 09:16:54 BST."
             <1062663414.86530.15.camel@herring.nlsystems.com> 
Date: Thu, 04 Sep 2003 10:35:15 +0200
Message-ID: <1199.1062664515@critter.freebsd.dk>
X-OriginalArrivalTime: 04 Sep 2003 08:35:26.0333 (UTC)
	FILETIME=[7D51AAD0:01C372BF]
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: "M. Warner Losh" <imp@bsdimp.com>
Subject: Re: cvs commit: src/sys/pci if_sis.c if_sisreg.h 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Sep 2003 08:35:30 -0000

In message <1062663414.86530.15.camel@herring.nlsystems.com>, Doug Rabson write
s:

>For specific drivers, if they really want to change the device
>description in attach (why not do it in probe like every other driver),

In the case of the sis driver, the "silicon revision register" is
stored somewhere in BAR0, so I cannot examine it until the resources
are allocated.

I know there are other drivers which could be similarly more detailed
of the description were set in attach rather than probe.

I think postpoining the print to after attach might make sense.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.