Date: Wed, 24 Sep 1997 00:06:34 +0100 From: Brian Somers <brian@awfulhak.org> To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru> Cc: Brian Somers <brian@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/ppp modem.c Message-ID: <199709232306.AAA07852@awfulhak.demon.co.uk> In-Reply-To: Your message of "Wed, 24 Sep 1997 02:29:11 %2B0400." <Pine.BSF.3.96.970924021826.7008A-100000@lsd.relcom.eu.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Tue, 23 Sep 1997, Brian Somers wrote: > > > brian 1997/09/23 15:09:46 PDT > > > > Modified files: (Branch: RELENG_2_2) > > usr.sbin/ppp modem.c > > Log: > > MFC: Don't use uu_lock in -direct mode. It conflicts w/ > > hylafax & the like. > > Early or later you'll return to model I describe: treat -direct as > stdin/stdout only without any additional assumptions :-) > > It seems that hylafax lock modem before open (like any soft who open > modem). Moreover some soft can use its own tty modes for opened modem > which ppp may spam by CLOCAL set. Imagine f.e. that some upper level soft > open device as controlling terminal (assuming he got HUP or -1 from it > on carrier drop) then pass descriptor to ppp stdin. ppp spams tty modes > by its own CLOCAL, causing upper level soft never got HUP. > > I think ppp must not touch tty flags of passed descriptor as possible. > F.e. setting RAW mode is acceptable thing, but setting/removing HUP > handling is not acceptable. Then use both HUP catch function and TIOCM_CD > to handle carrier with fallback to carrier_always_ON if TIOCM_CD returns > -1. But in this case, surely ppp would never get anything from the modem - select() would never see anything as reading or writing to the modem would give a SIGTTIN or SIGTTOU. And if the parent isn't active, it wouldn't get the HUP anyway. If anyone can show me a practical, real-live situation where checking for carrier won't work and leaving -clocal and waiting for a HUP will, I'll modify the code. 'Till then, I'd rather leave it as it is. It'll make my eventual integration of Archie's mpd easier. > -- > Andrey A. Chernov > <ache@null.net> > http://www.nagual.pp.ru/~ache/ > -- Brian <brian@Awfulhak.org>, <brian@FreeBSD.org>, <bri@OpenBSD.org> <http://www.Awfulhak.org>; Don't _EVER_ lose your sense of humour....
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199709232306.AAA07852>