Date: Wed, 01 Oct 2003 23:20:30 +1000 From: Mark Smith <markfbsd@mark.alphadimensions.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: kern/57453: if_kue hangs warm boot if firmware is loaded - affects 4.9-RC - fix included Message-ID: <02llnv0q76gu2noo5gh55tf28od8bg008o@4ax.com> Resent-Message-ID: <200310011330.h91DUGcN004349@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 57453
>Category: kern
>Synopsis: if_kue hangs boot after warm boot if firmware is loaded
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Oct 01 06:30:14 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator: Mark Smith
>Release: FreeBSD 4.9-RC i386
>Organization:
-
>Environment:
System: FreeBSD server 4.9-RC FreeBSD 4.9-RC #9: Wed Oct 1 22:41:36 EST =
2003 root@server:/usr/obj/usr/src/sys/XLSERV
i386
>Description:
When I warm boot my machine I get a hang if the if_kue firmware is loaded=
already.
This is a hard lock up, and the system will not continue booting. Big =
Problem in
my view.
>How-To-Repeat:
Umm, that might be kind of difficult, unless you have access to my NIC.
>Fix:
This quote from if_kue.c explains why:
-----------
/*
* First, check if we even need to load the firmware.
* If the device was still attached when the system was
* rebooted, it may already have firmware loaded in it.
* If this is the case, we don't need to do it again.
* And in fact, if we try to load it again, we'll hang, <<<<<<<<<<<
* so we have to avoid this condition if we don't want <<<<<<<<<<<<
* to look stupid.
*
* We can test this quickly by checking the bcdRevision
* code. The NIC will return a different revision code if
* it's probed while the firmware is still loaded and
* running.
*/
if (hwrev =3D=3D 0x0202)
return(0);
-----------
If I change this code to
if ((hwrev & 0xfff0) =3D=3D 0x0200)
return(0);
It fixes the problem (my card reports 0x0208 when firmware is loaded, not=
0x0202!)
This affect 4.9-RC, and as such this should be put in as an urget fix (I =
think anyway).
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?02llnv0q76gu2noo5gh55tf28od8bg008o>