Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Jan 1999 13:59:38 +0200
From:      Sheldon Hearn <axl@iafrica.com>
To:        FreeBSD-gnats-submit@FreeBSD.ORG
Subject:   ports/9488: [PATCH] audio/mpg123: doesn't honour local CFLAGS
Message-ID:  <33700.916315178@axl.noc.iafrica.com>

next in thread | raw e-mail | index | archive | help

>Number:         9488
>Category:       ports
>Synopsis:       [PATCH] audio/mpg123: doesn't honour local CFLAGS
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 14 04:10:00 PST 1999
>Closed-Date:
>Last-Modified:
>Originator:     Sheldon Hearn
>Release:        FreeBSD 3.0-CURRENT i386
>Organization:
UUNET Internet Africa
>Environment:

	N/A

>Description:

	The audio/mpg123 port includes a FreeBSD patch that ignores
	local CFLAGS.

>How-To-Repeat:

	Watch the port build with CFLAGS+='-DI_AM_IGNORED'.

>Fix:
	
	The following diff teaches the wayward patch-aa to honour local
	CFLAGS.

Index: ports/audio/mpg123/patches/patch-aa
===================================================================
RCS file: /home/ncvs/ports/audio/mpg123/patches/patch-aa,v
retrieving revision 1.5
diff -u -d -r1.5 patch-aa
--- patch-aa	1998/11/25 01:30:34	1.5
+++ patch-aa	1999/01/06 12:00:08
@@ -14,7 +14,7 @@
  		OBJECTS='decode_i386.o dct64_i386.o getbits_.o audio_oss.o' \
 -		CFLAGS='-Wall -ansi -pedantic -O4 -m486 -fomit-frame-pointer \
 -			-funroll-all-loops -ffast-math -DROT_I386 \
-+		CFLAGS+='-Wall -O2 -ansi -pedantic -fomit-frame-pointer \
++		CFLAGS+='$(CFLAGS) -Wall -ansi -pedantic -fomit-frame-pointer \
 +			-funroll-all-loops -ffast-math -DROT_I386 -DREAD_MMAP \
 +			-DI386_ASSEM -DREAL_IS_FLOAT -DUSE_MMAP -DOSS' \
 +		mpg123-make
@@ -22,7 +22,7 @@
 +freebsd-elf:
 +	$(MAKE) CC=cc LDFLAGS= \
 +		OBJECTS='decode_i386.o dct64_i386.o getbits.o audio_oss.o' \
-+		CFLAGS+='-Wall -O2 -ansi -pedantic -fomit-frame-pointer \
++		CFLAGS+='$(CFLAGS) -Wall -ansi -pedantic -fomit-frame-pointer \
 +			-funroll-all-loops -ffast-math -DROT_I386 -DREAD_MMAP \
  			-DI386_ASSEM -DREAL_IS_FLOAT -DUSE_MMAP -DOSS' \
  		mpg123-make
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?33700.916315178>