From owner-cvs-src@FreeBSD.ORG Wed Oct 29 21:28:33 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 57AB316A4CE; Wed, 29 Oct 2003 21:28:33 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id E217C43FA3; Wed, 29 Oct 2003 21:28:29 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.9p2/8.12.9) with ESMTP id h9U5STE7038936; Wed, 29 Oct 2003 22:28:29 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 29 Oct 2003 22:28:28 -0700 (MST) Message-Id: <20031029.222828.133432192.imp@bsdimp.com> To: nate@root.org From: "M. Warner Losh" In-Reply-To: <20031029210945.A86732@root.org> References: <20031029100945.F84859@root.org> <20031029.220629.102576808.imp@bsdimp.com> <20031029210945.A86732@root.org> X-Mailer: Mew version 2.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf options src/sys/i386/acpica Makefile acpi_wakecode.S src/sys/i386/conf NOTES X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Oct 2003 05:28:33 -0000 In message: <20031029210945.A86732@root.org> Nate Lawson writes: : On Wed, 29 Oct 2003, M. Warner Losh wrote: : > In message: <20031029100945.F84859@root.org> : > Nate Lawson writes: : > : On Wed, 29 Oct 2003, M. Warner Losh wrote: : > : > In message: <20031028235425.N82902@root.org> : > : > Nate Lawson writes: : > : > : Is this needed? options alone should be sufficient and acpi_wakeup.S : > : > : should include opt_acpi.h. : > : > : > : > Not for kernel modules... : > : : > : Muagh. : > : : > : Ok, I'm starting a pot for whoever will finally implement the combined : > : kernel modules and kernel config build tree. $10 US via PayPal. Care to : > : contribute? : > : > Not for this. Options for kernel compilation should only really be : > used for ABI issues. better to make this a tunable/sysctl. : : Non-sequitur. Not a non-sequitur. We're moving away from kernel options for things that are tunable. I'm pointing out that this is the case here and we should recognize it. Your desire for opt_*.h stuff is the non-sequitur :-). : The issue still stands that module builds don't pull in the : kernel config file, forcing duplication in make.conf. Not entirely true. We tend to build modules that have all the options turned on. The world view is that opt_foo is used for big options to leave in/out, not change minor runtime behavor. : When building a : kernel+modules, options in opt_*.h should be included in the module build. Agreed, it basically should. I'm just saying that this isn't a good reason for it, and we should be fixing the right problem. : This is even under the 5.2-TODO as "Revised kld build infrastructure". I : was just indicating that the number of times this has bothered me was : worth $10 to the author of the fix. Maybe it's bothered enough others : that it's worth a few hundred $ aggregate. :) : : I'll up it to $20. Patches have been posted for about 90% of the problem. However, the last 10% is hard. How do you deal with people that build the modules outside of the kernel tree, so there is no kernel opt_*.h files. This happens for third parties with drivers, as well as developers making changes and loading modules. That's why things haven't been committed: there's not been a good way proposed with how to deal with this part of the problem. You'd still have the problem with acpi if I cd to sys/modules/acpi and type make. And that's why I harped on this needing to be a tunable/sysctl in my last message. Warner