From owner-freebsd-ports@FreeBSD.ORG  Sat Aug 11 17:33:20 2007
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DBF7916A46B;
	Sat, 11 Aug 2007 17:33:20 +0000 (UTC)
	(envelope-from delphij@delphij.net)
Received: from tarsier.geekcn.org (tarsier.geekcn.org [210.51.165.229])
	by mx1.freebsd.org (Postfix) with ESMTP id 8DE2A13C45E;
	Sat, 11 Aug 2007 17:33:20 +0000 (UTC)
	(envelope-from delphij@delphij.net)
Received: from localhost (tarsier.geekcn.org [210.51.165.229])
	by tarsier.geekcn.org (Postfix) with ESMTP id A6F6CEB5C62;
	Sun, 12 Aug 2007 01:33:18 +0800 (CST)
X-Virus-Scanned: amavisd-new at geekcn.org
Received: from tarsier.geekcn.org ([210.51.165.229])
	by localhost (mail.geekcn.org [210.51.165.229]) (amavisd-new,
	port 10024)
	with ESMTP id g3S0jvq+ENjD; Sun, 12 Aug 2007 01:33:15 +0800 (CST)
Received: from charlie.delphij.net (unknown [221.222.200.146])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by tarsier.geekcn.org (Postfix) with ESMTP id E1990EB5C5F;
	Sun, 12 Aug 2007 01:33:14 +0800 (CST)
DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns;
	h=message-id:date:from:user-agent:mime-version:cc:subject:
	references:in-reply-to:content-type:content-transfer-encoding;
	b=K0vduPnwDUuKThv1Ffko91t8BjtgayeB0LWZazWFSJnFL7Bdun+rzBCW38YiSNLMm
	sVqC/aSxFofrn4mwgLOow==
Message-ID: <46BDF2DA.8070906@delphij.net>
Date: Sun, 12 Aug 2007 01:33:14 +0800
From: Xin LI <delphij@delphij.net>
User-Agent: Thunderbird 2.0.0.6 (X11/20070803)
MIME-Version: 1.0
References: <70f41ba20708110931i4262c224kd0479290616c4fa8@mail.gmail.com>	
	<46BDEA06.9030503@delphij.net>
	<70f41ba20708111013g296134ecw57bf152846718e91@mail.gmail.com>
In-Reply-To: <70f41ba20708111013g296134ecw57bf152846718e91@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: krion@freebsd.org, freebsd-ports@freebsd.org
Subject: Re: request add db45/db46 support to mail/exim port
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Aug 2007 17:33:20 -0000

snowcrash+freebsd wrote:
> hi,
> 
>> Sounds great, just one point: I'd prefer seeing that exim would make use
>> of bsd.database.mk.
> 
> i /thought/ that use of WITH_BDB_VER/USE_BDB *is* 'making use of'
> bsd.database.mk, wherein,
> 
>  ...
>  .if defined(WITH_BDB_VER)
>  . if ${WITH_BDB_VER} == 4
>  USE_BDB=    40
>  . elif ${WITH_BDB_VER} != 1
>  USE_BDB=    ${WITH_BDB_VER}
>  . endif
>  .endif
>  _WANT_BDB_VER=  ${USE_BDB}

Em...  What I mean is that exim should rely on bsd.database.mk to choose 
BDB version, if possible.  This could be something like:

.if !defined(WITHOUT_BDB)
WITH_BDB_VER?=	46
USE_BDB=	yes
.endif

DB_INCLUDES=	-I${BDB_INCLUDE_DIR}
DB_LIBS=	-L${LOCALBASE}/lib -l${BDB_LIB_NAME:R}

But I do not have some test with it, though...  This way, exim will 
automatically pick up with bsd.database.mk changes.

Just my $0.02 :-)

Cheers,