From owner-cvs-all@FreeBSD.ORG Mon Aug 2 14:26:41 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 422F016A4CE for ; Mon, 2 Aug 2004 14:26:41 +0000 (GMT) Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B88843D48 for ; Mon, 2 Aug 2004 14:26:41 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 30990 invoked from network); 2 Aug 2004 14:26:40 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 2 Aug 2004 14:26:40 -0000 Received: from 10.50.40.208 (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i72EQatx017473; Mon, 2 Aug 2004 10:26:36 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Brian Fundakowski Feldman Date: Fri, 30 Jul 2004 15:32:24 -0400 User-Agent: KMail/1.6 References: <200407300910.i6U9ASg5077534@repoman.freebsd.org> <20040730160645.GB33220@green.homeunix.org> In-Reply-To: <20040730160645.GB33220@green.homeunix.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200407301532.24968.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Maxime Henrion cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_map.c vm_map.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Aug 2004 14:26:41 -0000 On Friday 30 July 2004 12:06 pm, Brian Fundakowski Feldman wrote: > On Fri, Jul 30, 2004 at 09:10:28AM +0000, Maxime Henrion wrote: > > mux 2004-07-30 09:10:28 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/vm vm_map.c vm_map.h > > Log: > > Get rid of another lockmgr(9) consumer by using sx locks for the user > > maps. We always acquire the sx lock exclusively here, but we can't > > use a mutex because we want to be able to sleep while holding the > > lock. This is completely equivalent to what we were doing with the > > lockmgr(9) locks before. > > Not that I don't think it's worth doing in general, but is there a > comparison anyone has done between speeds of sx and lockmgr? Speed aside, when allproc_lock and proctree_lock were lockmgr locks (before sx was implemented), my SMP machines routinely locked up and when I looked at things in the debugger it seemed that no one held allproc_lock but several processes were blocked on it. Quite frankly, I don't trust lockmgr()'s implementation. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org