From owner-freebsd-current  Sat Apr 27 09:46:45 1996
Return-Path: owner-current
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id JAA24619
          for current-outgoing; Sat, 27 Apr 1996 09:46:45 -0700 (PDT)
Received: from austin.polstra.com (austin.polstra.com [206.213.73.10])
          by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id JAA24614
          for <current@FreeBSD.ORG>; Sat, 27 Apr 1996 09:46:42 -0700 (PDT)
Received: from austin.polstra.com (jdp@localhost) by austin.polstra.com (8.7.5/8.6.12) with ESMTP id JAA15176; Sat, 27 Apr 1996 09:41:33 -0700 (PDT)
Message-Id: <199604271641.JAA15176@austin.polstra.com>
To: ache@astral.msk.su, phk@critter.tfs.com
Cc: joerg_wunsch@uriah.heep.sax.de, current@FreeBSD.ORG
Subject: Re: local router<->router UDP traffic: log_in_vain stuff error
In-reply-to: <199604271209.QAA07239@astral.msk.su>
Date: Sat, 27 Apr 1996 09:41:33 -0700
From: John Polstra <jdp@polstra.com>
Sender: owner-current@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> > Uhm this doesn't make any sense to me, the log_in_vain change was the
> > addition of this bit of code:
> > 
> >                 if (log_in_vain)
> >                         log(LOG_INFO, "Connection attempt to UDP %s:%d"
> >                             " from %s:%d\n",
> >                                 inet_ntoa(ip->ip_dst), ntohs(uh->uh_dport),
> >                                 inet_ntoa(ip->ip_src), ntohs(uh->uh_sport));
> > 
> 
> Maybe ip->ip_src not properly evaluated there.

Inet_ntoa formats its result into a static buffer.  It doesn't work to
have two calls to it in a single expression.
--
   John Polstra                                       jdp@polstra.com
   John D. Polstra & Co., Inc.                Seattle, Washington USA
   "Self-knowledge is always bad news."                 -- John Barth