From nobody Fri Feb 3 02:12:29 2023 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P7K1K2dQ8z3krCD for ; Fri, 3 Feb 2023 02:12:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P7K1J514hz41n6 for ; Fri, 3 Feb 2023 02:12:36 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=X3qKYbnR; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2a00:1450:4864:20::62b) smtp.mailfrom=wlosh@bsdimp.com; dmarc=none Received: by mail-ej1-x62b.google.com with SMTP id mc11so11498511ejb.10 for ; Thu, 02 Feb 2023 18:12:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=XTurOAsvYoIOlEjZgLeKqxdgGKTi3ft3g5Uc5KCGRHY=; b=X3qKYbnRs2RVhWBQudeXg9tZBcrW0ny0UX17UDR/br6Y4W7xpj8K8wtpAH7olsC8LX uruWoJut8c3KzFCwmGxF6GO7r5vlnif8TBhAMnLJzx7dZ3SGwDnDG0eGiIY5R5FO7T6X GUZBNVHo4INIFkGDsG+givIkRspdY2iHBED2Qpq9QZppIQk5z1MMD74uJ41vkBV70+Jm sRMh985gO0bVr4eqDBhwuAudpHYIHgLZMJRL291ZFbvUICN6r0RnYq88Yey4OqlTeaOW 2IaenbMHfgYzCDcl3rbOZ7mAlMwABYaDHf1jcEWOQSsVdx9tFJx2oVHygq2YBFPTc7P2 41lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=XTurOAsvYoIOlEjZgLeKqxdgGKTi3ft3g5Uc5KCGRHY=; b=sLbfoMfMdbfhfMZUt62KhhWBTBeEL739382qBwIJjxNuLg6SlcrTi/ryW2QIKPgIK1 rTNKdHg7Jn/9qCL8dWhi9az2rYkydH97F/JLYrtD1e/XlUemUDjg/gHodwhSQECfcn44 a3vrbVgoNu4qcYP9931q7lN/PjOxVX0GRYjybMvS9coOgDLe6Z2nv1Xyhpqf9l2UQzzm Wt9nUl1R1zsqV9XVy+w+oGQvKy1UpcIb3dS768W7yeSjBj+lOLynPGwDV9H2rRl801F2 TEmI6NzC6iXaACmOkxE95Y52Ea8osF/24KclL80LfMmGqivh8h5PBwxwxXwi+dSlmE2H iMUQ== X-Gm-Message-State: AO0yUKWE6HOqgAwKznZ6UvzCeSBHVK6teBAJ06QX6Xb8NwlYjxh24Ax6 oNVdrLBU9v4ltVC6jhDVoxi/1223WdcxoDA4Vt/wspE35hCESA== X-Google-Smtp-Source: AK7set8AZCBn1AqLh7eDW7BYBye+w+LFRcX5N5Bvbi6bEfvV6E6pBc7fARRx/CbtTG86NFoGncXfOCCbOIg65j9BR8I= X-Received: by 2002:a17:906:d96d:b0:888:c14e:70b6 with SMTP id rp13-20020a170906d96d00b00888c14e70b6mr2722642ejb.306.1675390353644; Thu, 02 Feb 2023 18:12:33 -0800 (PST) List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 From: Warner Losh Date: Thu, 2 Feb 2023 19:12:29 -0700 Message-ID: Subject: Proposed Github Pull Request Policy To: freebsd-git Content-Type: multipart/alternative; boundary="000000000000e3b57905f3c236ba" X-Spamd-Result: default: False [-2.94 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.94)[-0.940]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::62b:from]; MLMMJ_DEST(0.00)[freebsd-git@freebsd.org]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_SPF_NA(0.00)[no SPF record]; ARC_NA(0.00)[]; TO_DN_ALL(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; PREVIOUSLY_DELIVERED(0.00)[freebsd-git@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; DMARC_NA(0.00)[bsdimp.com]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4P7K1J514hz41n6 X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N --000000000000e3b57905f3c236ba Content-Type: text/plain; charset="UTF-8" Geetngs, I'd like to put some parameters around the pull requests on github. To that end, I'd like us to consider the following policy: In general, pull requests should be small, easily reviewable and solve real problems. The pull requests should be small enough that developers can look at them and decide quickly if the request should be (a) committed (b) revised or (c) rejected. To that end: Please limit pull requests to about 200 or so lines of changes, spread across no more than 10 commits. Each independent change should get a new pull request (though groups of closely related changes should be in one). Subitter should be responsive to feedback. The pull requests should be changes that are ready to land in the tree (or nearly so, based on review). Pull requests shouldn't expand in scope in response to feedback: If the feedback suggests a new series of changes, please create a new pull requests. Do not submit 'omnibus' branches that have no unifying theme. Please respect requests to take reviews to phabricator, and close the pull request on github when you do that. Please do not submit pull requests that don't conform to these guidelines unless you have a good reason, like: (1) You are arranging with others to do the review on github. (2) The review is a poor fit for phabricator, but a good fit for github Idle pull requests that are outside of these guidelines will be closed. --000000000000e3b57905f3c236ba Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Geetngs,

I'd like to put= some parameters around the pull requests on github. To that end, I'd l= ike us to consider the following policy:

In genera= l, pull requests should be small, easily reviewable and solve real problems= . The pull requests should be small enough that developers can look at them= and decide quickly if the request should be (a) committed (b) revised or (= c) rejected.

To that end:

=
Please limit pull requests to about 200 or so lines of changes, spread= across no more than 10 commits. Each independent change should get a new p= ull request (though groups of closely related changes should be in one). Su= bitter should be responsive to feedback. The pull requests should be change= s that are ready to land in the tree (or nearly so, based on review).
=

Pull requests shouldn't expand in scope in response= to feedback: If the feedback suggests a new series of changes, please crea= te a new pull requests.

Do not submit 'omnibus= ' branches that have no unifying theme.

Please= respect requests to take reviews to phabricator, and close the pull reques= t on github when you do that.

Please do not su= bmit pull requests that don't conform to these guidelines unless you ha= ve a good reason, like:
(1) You are arranging with others to do t= he review on github.
(2) The review is a poor fit for phabricator= , but a good fit for github

Idle pull requests tha= t are outside of these guidelines will be closed.
--000000000000e3b57905f3c236ba--