From owner-cvs-src@FreeBSD.ORG Thu Nov 18 04:14:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A515416A4CE; Thu, 18 Nov 2004 04:14:32 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 94FD043D49; Thu, 18 Nov 2004 04:14:32 +0000 (GMT) (envelope-from gibbs@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id iAI4EW2T018260; Thu, 18 Nov 2004 04:14:32 GMT (envelope-from gibbs@repoman.freebsd.org) Received: (from gibbs@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id iAI4EWKb018259; Thu, 18 Nov 2004 04:14:32 GMT (envelope-from gibbs) Message-Id: <200411180414.iAI4EWKb018259@repoman.freebsd.org> From: "Justin T. Gibbs" Date: Thu, 18 Nov 2004 04:14:32 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/cam cam_xpt.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Nov 2004 04:14:32 -0000 gibbs 2004-11-18 04:14:32 UTC FreeBSD src repository Modified files: sys/cam cam_xpt.c Log: Correct an off-by-one in the calculation of the inquiry buffer length to request from devices during the "long inquiry" portion of our probe. This same bug was fixed in the 4.x stream a few years ago, but the fix was never propogated to -current. This fix is slightly different than in -stable: o Use offsetof() instead of a hard coded constant so as the make the code more self-explainatory. o Round odd long inquiry lengths up so as to avoid tickling ignore wide residue bugs in broken parallel SCSI devices running with a wide transfer negotiation. MFC: 3 days Revision Changes Path 1.144 +11 -1 src/sys/cam/cam_xpt.c