From owner-p4-projects@FreeBSD.ORG  Fri Aug  1 10:22:05 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C798837B404; Fri,  1 Aug 2003 10:22:04 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 79CEA37B401; Fri,  1 Aug 2003 10:22:04 -0700 (PDT)
Received: from milla.ask33.net (milla.ask33.net [217.197.166.60])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B655B43FBD; Fri,  1 Aug 2003 10:22:03 -0700 (PDT)
	(envelope-from nick@milla.ask33.net)
Received: by milla.ask33.net (Postfix, from userid 1001)
	id D9F5C3ABB4C; Fri,  1 Aug 2003 19:23:26 +0200 (CEST)
Date: Fri, 1 Aug 2003 19:23:26 +0200
From: Pawel Jakub Dawidek <nick@garage.freebsd.pl>
To: Robert Watson <rwatson@FreeBSD.org>
Message-ID: <20030801172326.GP43543@garage.freebsd.pl>
References: <200308010147.h711l3P8026025@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-md5;
	protocol="application/pgp-signature"; boundary="seGp1e/yLldw2teC"
Content-Disposition: inline
In-Reply-To: <200308010147.h711l3P8026025@repoman.freebsd.org>
X-PGP-Key-URL: http://garage.freebsd.pl/jules.asc
X-OS: FreeBSD 4.8-RELEASE i386
X-URL: http://garage.freebsd.pl
User-Agent: Mutt/1.5.1i
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 35304 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Aug 2003 17:22:05 -0000


--seGp1e/yLldw2teC
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 31, 2003 at 06:47:03PM -0700, Robert Watson wrote:
+> Differences ...
+>=20
+> =3D=3D=3D=3D //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#395 (te=
xt+ko) =3D=3D=3D=3D
+>=20
+> @@ -203,6 +203,9 @@
+>      nmacsockets, nmacmounts, nmactemp, nmacvnodes, nmacdevfsdirents,
+>      nmacipqs, nmacpipes, nmacprocs;
+> =20
+> +#define	MAC_DEBUG_COUNTER_INC(x)	atomic_add_int(x, 1);
+> +#define	MAC_DEBUG_COUNTER_DEC(x)	atomic_subtract_int(x, 1);
+> +
+>  SYSCTL_UINT(_security_mac_debug_counters, OID_AUTO, mbufs, CTLFLAG_RD,
+>      &nmacmbufs, 0, "number of mbufs in use");
+>  SYSCTL_UINT(_security_mac_debug_counters, OID_AUTO, creds, CTLFLAG_RD,
+> @@ -227,6 +230,9 @@
+>      &nmacvnodes, 0, "number of vnodes in use");
+>  SYSCTL_UINT(_security_mac_debug_counters, OID_AUTO, devfsdirents, CTLFL=
AG_RD,
+>      &nmacdevfsdirents, 0, "number of devfs dirents inuse");
+> +#else
+> +#define	MAC_DEBUG_COUNTER_INC(x)
+> +#define	MAC_DEBUG_COUNTER_INC(x)

I susspect, that one of those should be MAC_DEBUG_COUNTER_DEC(x).

--=20
Pawel Jakub Dawidek                       pawel@dawidek.net
UNIX Systems Programmer/Administrator     http://garage.freebsd.pl
Am I Evil? Yes, I Am!                     http://cerber.sourceforge.net

--seGp1e/yLldw2teC
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iQCVAwUBPyqiDj/PhmMH/Mf1AQG7NgQAhEey1NwiniyNV3evk02gRtzEjFSKkXFr
dDqXSB/lCjPJwK2vlP6zSZNaAkBbZoOhyAfe6NlL6147d6NYn7G3/3f1veHi/CEB
gva9dTLqr1C8cSZukot5GajVF3As2oRAskz4/dVvfsVZV1eCzRi9U7Qk2Y/wUNFZ
eoc4JEpcGi8=
=24Ds
-----END PGP SIGNATURE-----

--seGp1e/yLldw2teC--