From owner-freebsd-ports-bugs@freebsd.org Tue Jan 22 12:40:33 2019 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B77F14BB8C8 for ; Tue, 22 Jan 2019 12:40:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id C9FEE8A76B for ; Tue, 22 Jan 2019 12:40:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 8CFD014BB8C6; Tue, 22 Jan 2019 12:40:32 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B49014BB8C5 for ; Tue, 22 Jan 2019 12:40:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1A16F8A766 for ; Tue, 22 Jan 2019 12:40:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 6093414E72 for ; Tue, 22 Jan 2019 12:40:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x0MCeVHS049436 for ; Tue, 22 Jan 2019 12:40:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x0MCeVnM049428 for ports-bugs@FreeBSD.org; Tue, 22 Jan 2019 12:40:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 231806] [NEW PORT] math/libnormaliz: computations in affin monoids, vector configurations etc Date: Tue, 22 Jan 2019 12:40:31 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2019 12:40:33 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D231806 --- Comment #8 from Tobias Kortkamp --- Comment on attachment 197690 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D197690 shar file of libnormaliz - correction 3 I do not understand what the flavors are supposed to do. Can you explain what the intent behind them is here? XBUILD_WRKSRC=3D ${WRKSRC}/source/libnormaliz XINSTALL_WRKSRC=3D ${WRKSRC}/source/libnormaliz X XCXXFLAGS+=3D -I ${LOCALBASE}/include XMAKEFILE=3D Makefile.classic These are all framework variables and in the wrong place. XHEADERSDIR=3D ${PREFIX}/include/libnormaliz This custom variable is only used twice. Maybe inline it instead. X for x in cone.h cone_property.h convert.h general.h HilbertSeries.h integer.h libnormaliz.h map_operations.h matrix.h my_omp.h normaliz_excepti= on.h sublattice_representation.h vector_operations.h version.h nmz_integrate.h; = do ${INSTALL_DATA} ${INSTALL_WRKSRC}/$$x ${STAGEDIR}${HEADERSDIR}; done It would be better to use a .for loop here, or even without one at all like cd ${INSTALL_WRKSRC} && ${INSTALL_DATA} cone.h cone_propery.h ... ${STAGEDIR}${PREFIX}/include/libnormaliz pkg-plist is badly ordered. Please use the order as output by `make makeplist`. --=20 You are receiving this mail because: You are the assignee for the bug.=