From owner-freebsd-hackers@FreeBSD.ORG Tue Jul 23 15:35:17 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 26BC3D7F; Tue, 23 Jul 2013 15:35:17 +0000 (UTC) (envelope-from jiashiun@gmail.com) Received: from mail-oa0-x22f.google.com (mail-oa0-x22f.google.com [IPv6:2607:f8b0:4003:c02::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DCAC124D9; Tue, 23 Jul 2013 15:35:16 +0000 (UTC) Received: by mail-oa0-f47.google.com with SMTP id m1so1711855oag.34 for ; Tue, 23 Jul 2013 08:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=Dl3ew/qWIkNssY/tnrsJaeZh+kDOYfA3U7CcUKW1AW8=; b=w6E07htIMtGlUHj1NASNTwHDIZbGYAMcoH66lHKhal8pFTVYUORZeQdFXRMPhldK0U Polwd/mkU7BF0tiRZ5rpkskOyrWjBVEW1j/tAF3vpSnbHYNG1N8vmUJHAZg7JVfZhipl X8NarbUpbdh8wOoIHAq9bZk1aRJ+Q0VTq/ZnS7xjvpeSGeo6rNbyuj5i7A/+EEigX/a5 3IEdIe4YJXxILf5Pj8BaJrVRJi9l9WnOger+Y71p1xZAIllx9JVA+bHIynhswSkTsqIS lxuF1jWGb5a/BHkWh1nZmCG9/Oto5/6/zyJOQUcNlGvKQ5emL3Mg37/natAIr1dZHim9 MFVw== X-Received: by 10.60.45.38 with SMTP id j6mr31218522oem.56.1374593716248; Tue, 23 Jul 2013 08:35:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.76.130.204 with HTTP; Tue, 23 Jul 2013 08:34:46 -0700 (PDT) In-Reply-To: References: <20110129084125.GA54969@freebsd.org> <20130108150155.GF82219@kib.kiev.ua> From: Jia-Shiun Li Date: Tue, 23 Jul 2013 23:34:46 +0800 Message-ID: Subject: Re: cpufreq not working as module on i386/amd64 To: Konstantin Belousov Content-Type: text/plain; charset=UTF-8 Cc: freebsd-hackers@freebsd.org, Andriy Gapon X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jul 2013 15:35:17 -0000 On Thu, Jul 4, 2013 at 1:37 PM, Jia-Shiun Li wrote: > ok anyone can help test and review this patch? > > It will allow cpufreq to be removed from kernel conf, loaded and > function correctly as kernel module. I've tested it ok on my own > i5-3450. > > It removes get_features method definition from acpi_if.m and > corresponding implementations from est, p4tcc, & hwpstate. Feature > flags are set directly in acpi_cpu.c omitting previous procedure of > querying cpufreq drivers. > I submitted the patch as PR kern/180588. Could anyone help review and get this committed? Thanks, Jia-Shiun.