From owner-svn-src-head@freebsd.org Tue Apr 10 00:39:21 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5D248F8C58F; Tue, 10 Apr 2018 00:39:21 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DD9AD76A73; Tue, 10 Apr 2018 00:39:20 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it0-x236.google.com with SMTP id 15-v6so12654961itl.1; Mon, 09 Apr 2018 17:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=+J9iqXZFvIgvyLERMoSmzE53hieHEb96jkcbgW6Lr4E=; b=lj7NX1gpYVtNvQO0LSBiGjrRSVsPclvjs6XMAhIgxeuVapiekpd3B9KdgBZxatAVWk vH297c+aynj2Cf2TzXL14J4+r2XiAc1iXWpi3lg9B8wJa/L50ktn9C8pTBfzZw773FW3 pAFnKqBwZHs9IkSxh7fwGgiYe+c+6csMlqmLOEZoKBMSVu4RMcIv62f6Kxd9f2N9bYdA fTzhiNR17nQIJLdpT6qvRd2dgFrhokIOMuW/CveOzHJLJVDIcMIcZ4vEEZ5EWONFqxqw o0rqRVI7DQVePTUZotyA1IEHcPvdFrPDDmtm24F9TNE6FZ6DBJ26LrH8fFxgAYxUr36u 0CpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=+J9iqXZFvIgvyLERMoSmzE53hieHEb96jkcbgW6Lr4E=; b=inwex4HojUTOPa8Nsyvb8Wf7iH1i0PF1XSPUiJbG/acaffjclEIIH36+H7jHZlXSrA vRL0XHXuIxfs9sWzUuGlfE+4IPb2LCoX6ih5jDRK6DvMKQqhLReKpw7YAW/TbXkup+5T r4rYhj0Bn6gFeltzewbgTJZAl3ms1Sg4FnEN1iFJIkbZsBw9rYHmc7w5QV9rdbIZ/neo FMTqP9x5BA4uWhIfqzHH+Hx0lgteKVo0UQKb7wEv7s6BwlbUDex4XJcj69SN4moJHEle 7GouqIzTmXQK7BfnWcAS28+rIjI4BTC6i/5j57x/sPZBx791pjhznoJK9EBi5eeEEQ6F 3LWQ== X-Gm-Message-State: ALQs6tAnF4KaievVMtsIsIBvpbQ+TK08KqMBWlk4pzGyk7Ah/BtrRwDr K/hdSdk59Jjdy1DejMOuVMpJrlpQq31t9qiGrQDc3dnd X-Google-Smtp-Source: AIpwx4+5MIkSBBUNvIWLbDPLBzKBIZrjNpbgsYqgJvBI54xNObDP87HtUGy/CaChbcpEXZJUjGqJhrpqo/tF+LlGqGI= X-Received: by 2002:a24:a0c6:: with SMTP id o189-v6mr58205ite.52.1523320760193; Mon, 09 Apr 2018 17:39:20 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.130.197 with HTTP; Mon, 9 Apr 2018 17:38:59 -0700 (PDT) In-Reply-To: <3188731.iHBUE9bOzj@ralph.baldwin.cx> References: <201804060257.w362vwi3023158@repo.freebsd.org> <3188731.iHBUE9bOzj@ralph.baldwin.cx> From: Ed Maste Date: Mon, 9 Apr 2018 20:38:59 -0400 X-Google-Sender-Auth: paa6-3UAbG1K_cTCzkBqn1WWE58 Message-ID: Subject: Re: svn commit: r332090 - head/stand/i386 To: John Baldwin Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 00:39:21 -0000 On 9 April 2018 at 15:28, John Baldwin wrote: > > I do think we are likely to have far fewer conditional LDFLAGS rather > than CFLAGS though. I think if we are only going to have 1 or 2 > instances in the tree then LDFLAGS.LINKER_TYPE might perhaps be > overkill, but if we think there will be several then I think it is > more readable. Indeed, I don't anticipate we'd end up with more than 1 or 2 instances, but even with only the single case today I think it is clearer (D14998).